1873202 - [CA][https://www.sportchek.ca] Province not captured in the address doorhanger

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Ina Popescu, Desktop QA]

Attachment: sportcheck.mp4

Found in

• Nightly 123.0a1

Affected versions

• Nightly 123.0a1

Tested platforms

• Affected platforms: Windows 10, macOS 11

Preconditions:

• install the en-CA build
• set in about:config the following:
  browser.search.region = CA
  extensions.formautofill.addresses.capture.v2.enabled = true
  extensions.formautofill.addresses.supported = on
  extensions.formautofill.heuristics.captureOnFormRemoval = true
  extensions.formautofill.heuristics.captureOnPageNavigation = true

Steps to reproduce

1. Add an item to cart and checkout as guest on https://www.sportchek.ca/en/
2. Fill in manually all the details

Expected result

• All the filled in values are captured in the "Save address" doorhanger.

Actual result

• Province not captured in the "Save address" doorhanger.

Regression range

• N/A

Additional notes

• The issue can not be reproduced in Google Chrome.
• Fathom Page

Comment 1

[Dimi Lee [:dimi]]

The website use a list of button to implement the select function for province field.
After users select a province, the data is filled in a hidden, non-focusable <input> field.

If we want to fix this issue, we will need to re-think how we deal with non-focusable or non-visible fields (See Bug 1847687)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:janikaneuberger, since you are the author of the regressor, bug 1847687, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847687

Comment 4

[Dimi Lee [:dimi]]

Should be fixed by 1880450

Comment 5

[Ina Popescu, Desktop QA]

Attachment: sportchek.png

I've tested this in Nightly 125.0a1 (2024-03-04) on Windows10 x64 but the doorhanger is displayed only when the pref extensions.formautofill.addresses.capture.requiredFields is left blank.
Province was still not captured in the doorhanger or stored.
Screenshot attached.

Should I file a separate issue for the fact that the doorhanger is not displayed when pref extensions.formautofill.addresses.capture.requiredFields=street-address,postal-code,address-level1,address-level2? Thanks.

Comment 6

[Johannes]

Attachment: Bug 1873202 - fix address capture doorhanger issues with province normalization r=dimi

and also fix punctuation issues while nopprmalizing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61fdffcaa163
fix address capture doorhanger issues with province normalization r=dimi

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/61fdffcaa163

Comment 9

[Ina Popescu, Desktop QA]

Attachment: sportcheck_address capture_country.png

I've replicated this issue in Nightly 125.0a1 (2024-03-04) on Windows10 x64.
Verified as fixed in the latest Nightly 126.0a1 (2024-03-24) on Windows10 x64 and macOS11 ARM where the issue no longer occurs.
I've noticed that the Country is currently being captured twice in the address doorhanger, as shown in the attachment. Should I proceed to open a new issue regarding this matter? Thanks

Comment 10

[Johannes]

Hi Ina,

the address form on this website describes province with country-prefix (CA-BC). The address summary displayed in the doorhanger directly displays this, not-normalized. If we want the summary to display the normalized Province value instead (BC in this case), (which I think would make sense), we could indeed use a new issue.

Comment 11

[Dimi Lee [:dimi]]

Hi Ina, could you help file a new issue for not showing the "normalized" province value? thank you!

Comment 12

[Ina Popescu, Desktop QA]

Thank you for confirming.
I've submitted Bug 1887730 to address the issue mentioned in Comment 9.
Marking this issue as VERIFIED FIXED.