shortcut-remove-button on Manage Extension Shortcuts of about:addons is not labeled
Categories
(Toolkit :: Add-ons Manager, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi)
References
(Blocks 2 open bugs)
Details
(Keywords: access)
Attachments
(1 file)
shortcut-remove-button control on Manage Extension Shortcuts of about:addons is missing an accessible name - users of assistive technology would not be able to know what is the purpose of this <button>
|
Assignee | |
Comment 1•2 years ago
|
||
shortcut-remove-button control on Manage Extension Shortcuts of about:addons is missing an accessible name - users of assistive technology would not be able to know what is the purpose of this <button>.
By adding an aria-label property we would provide a label to the icon button. This would allow toolkit/mozapps/extensions/test/browser/browser_manage_shortcuts_remove.js test to start passing a11y_checks, thus we would need to remove the fail-if notation from its test manifest as well.
Depends on D197831
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:ayeddi, could you consider increasing the severity?
For more information, please visit BugBot documentation.
|
|
Assignee | |
Comment 3•2 years ago
|
||
(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #2)
The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:ayeddi, could you consider increasing the severity?For more information, please visit BugBot documentation.
This is an access-s2 since an assistive technology users won’t have a way to know the purpose of the control. I think the BugBot wanted to nag Luca instead :)
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
I don't know whether s2 should automatically imply s4. Bug severities are documented at https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html
S2 is documented to be "Bugs that could reasonably be expected to cause a Firefox user to switch browsers, either because the severity is bad enough, or the frequency of occurrence is high enough."
This bug doesn't seem to fit that description. S1/S2 bugs are bugs with a high impact that should be prioritized.
In any case, there is a patch here, so the bug will eventually be resolved and the exact severity here does not matter.
|
|
Assignee | |
Comment 6•2 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #4)
I don't know whether s2 should automatically imply s4. Bug severities are documented at https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html
S2 is documented to be "Bugs that could reasonably be expected to cause a Firefox user to switch browsers, either because the severity is bad enough, or the frequency of occurrence is high enough."
This bug doesn't seem to fit that description. S1/S2 bugs are bugs with a high impact that should be prioritized.
In any case, there is a patch here, so the bug will eventually be resolved and the exact severity here does not matter.
Per the Accessibility Triage Guidelines, Accessibility Severity S2 applies to missing labels for screen reader users on icon buttons/links - this is a high severity issue (thus a11y-S2 flag) and is a shipblocker candidate, because users of assistive technology won't have a way to know what is the purpose of this control without an accessible name.
To avoid shipping these high severity issues that impact our disabled customers - there are about 27% of general population who have disability - we encourage teams to use Accessibility review flag on a new feature bug to request engineering accessibility review and catch and address a11y issues before they go into the release and affect users.
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•1 year ago
|
Description
•