1854647 - [meta] Investigate elements that are failing Tier 2 a11y_checks for Add-ons Manager

Status: NEW

(Toolkit :: Add-ons Manager, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, the failing tests were failed-if by the bug 1854646.

This task is to track the investigation into the reasons each of these tests failed and to be able to backtrack these tests once they're resolved.

Individual bugs to block the following bugs

1. (all) this meta bug
2. (Node is not accessible via accessibility API / Node is not focusable via the accessibility API / Node is enabled but disabled via the accessibility API) Bug 1848394 (a11y_checks_focusable)

Tests affected:

Result	Path	Error	Element ID	Element tagName	Element className
FAIL	toolkit/mozapps/extensions/test/browser/browser_addon_list_reordering.js	Node is not accessible via accessibility API		H1	header-name
FAIL	toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js	Node is not accessible via accessibility API		ADDON-CARD	
FAIL	toolkit/mozapps/extensions/test/browser/browser_globalwarnings.js	Node is not accessible via accessibility API		DIV	addon-name-container
FAIL	toolkit/mozapps/extensions/test/browser/browser_globalwarnings.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js	Node is not accessible via accessibility API		DIV	addon-name-container
FAIL	toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js	Node is not accessible via accessibility API		DIV	card addon
FAIL	toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js	Node is not accessible via accessibility API		DIV	container
FAIL	toolkit/mozapps/extensions/test/browser/browser_history_navigation.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_history_navigation.js	Node is not accessible via accessibility API		ADDON-CARD	
FAIL	toolkit/mozapps/extensions/test/browser/browser_history_navigation.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_detail_permissions.js	Node is not focusable via the accessibility API	details-deck-button-permissions	BUTTON	tab-button ghost-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js	Node is not accessible via accessibility API		DIV	addon-name-container
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_discover_view_clientid.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_list_view_recommendations.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_list_view.js	Node is not accessible via accessibility API		H1	header-name
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_list_view.js	Node is not accessible via accessibility API		PANEL-ITEM	
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_list_view.js	Node is not accessible via accessibility API		DIV	main-search
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_options_ui.js	Node is not focusable via the accessibility API	details-deck-button-details	BUTTON	tab-button ghost-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_options_ui.js	Node is not focusable via the accessibility API	details-deck-button-preferences	BUTTON	tab-button ghost-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_pending_updates.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_pending_updates.js	Node is not accessible via accessibility API		DIV	text-container
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_scroll_restoration.js	Node is not accessible via accessibility API		ADDON-CARD	
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_scroll_restoration.js	Node is not focusable via the accessibility API	details-deck-button-permissions	BUTTON	tab-button ghost-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_updates.js	Node is not accessible via accessibility API		DIV	
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_updates.js	Node is not focusable via the accessibility API	details-deck-button-release-notes	BUTTON	tab-button ghost-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_updates.js	Node is not focusable via the accessibility API	details-deck-button-details	BUTTON	tab-button ghost-button
FAIL	toolkit/mozapps/extensions/test/browser/browser_html_updates.js	Node is not focusable via the accessibility API		BUTTON	category
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_relative.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

The following tests passed on Try (job):

1. toolkit/mozapps/extensions/test/browser/browser_html_list_view_recommendations.js
2. toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js
3. toolkit/mozapps/extensions/test/xpinstall/browser_relative.js

Comment 2

[Anna Yeddi [:ayeddi]]

New failing tests (Try):

FAIL	toolkit/mozapps/extensions/test/browser/browser_html_list_view_recommendations.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button panel-footer-button	
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_relative.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button panel-footer-button	

Comment 3

[Anna Yeddi [:ayeddi]]

New failing tests (Try):

FAIL	toolkit/mozapps/extensions/test/browser/browser_manage_shortcuts_remove.js	"[SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.) - 
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_installchrome.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary footer-button	

Newly passing tests:

PASS	toolkit/mozapps/extensions/test/xpinstall/browser_relative.js
PASS	toolkit/mozapps/extensions/test/browser/browser_html_list_view_recommendations.js

Comment 4

[Anna Yeddi [:ayeddi]]

New test results (Try):

FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_amosigned_trigger_iframe.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_auth4.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_bug540558.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_httphash4.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button
PASS	toolkit/mozapps/extensions/test/xpinstall/browser_installchrome.js	We expect at least one assertion to fail because this test file is marked as fail-if in the manifest			
FAIL	toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_url.js	Node is not focusable via the accessibility API		button	popup-notification-primary-button primary panel-footer-button