1873353 - Please restore secondary sort order by date for "grouped by sort"

Status: UNCONFIRMED

(Thunderbird :: Folder and Message Lists, defect)

Description

[betterbird.project+13]

Bug 1866951 removed the ability to have groups in a "grouped by sort" view grouped by a user-selected secondary sort order:
https://hg.mozilla.org/comm-central/rev/c18e9a718aae#l1.58

This was replaced by using the value of mailnews.default_sort_order/mailnews.default_news_sort_order.

This is an unwanted degradation of long-established functionality. Please restore it.

Note that secondary sort is always active, only indicators are not displayed.

Comment 1

[betterbird.project+14]

After backing out bug 1866951, this patch fixes secondary sort for "grouped by sort".

diff --git a/mail/base/content/mailCommon.js b/mail/base/content/mailCommon.js
--- a/mail/base/content/mailCommon.js
+++ b/mail/base/content/mailCommon.js
@@ -965,16 +965,17 @@ var dbViewWrapperListener = {
       window.threadPane.setTreeView(gViewWrapper.dbView);
       // There is no persisted thread last expanded state for synthetic views.
       if (!gViewWrapper.isSynthetic) {
         window.threadPane.restoreThreadState();
       }
       window.threadPane.isFirstScroll = true;
       window.threadPane.scrollDetected = false;
       window.threadPane.scrollToLatestRowIfNoSelection();
+      window.threadPane.restoreSortIndicator();
     }
   },
   onDestroyingView(folderIsComingBack) {
     if (!window.threadTree) {
       return;
     }

     if (folderIsComingBack) {

It's unclear how that relates to https://hg.mozilla.org/releases/comm-esr115/rev/645d83496cba from bug 1860322 which has this commit message: "Disregard secondary sort order for Grouped By views."

Comment 2

[betterbird.project+14]

Attachment: 1873353-fix-secondary-sort-by-date-in-grouped-by-sort.patch