1873677 - Update Gradle to version 8.5 to match Firefox for Android version

Status: RESOLVED FIXED

(GeckoView :: General, task, P2)

Description

[Mihai Adrian Carare [:mcarare]]

https://docs.gradle.org/8.5/release-notes.html

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Upgrade Gradle and AGP

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Replace deprecated classifier with archiveClassifier

Depends on D198167

Comment 3

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Add namespace in build files.

Also remove the package from manifests.

Depends on D198168

Comment 4

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Enable buildConfig and aidl

Depends on D198169

Comment 5

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Set nonTransitiveRClass and nonFinalResIds build flags to false.

From Gradle 8 the default value has changed from false to true.

Depends on D198170

Comment 6

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Update script to keep the gradle distribution

Depends on D198171

Comment 7

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - GeckoView Android API 34 (Android 14)

Comment 8

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Upgrade Gradle to 8.5 version

Gradle 8.5 is still compatible with AGP 7.4.2, so upgrading AGP can be done as a follow-up.

gradle

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18ac798fd299
GeckoView Android API 34 (Android 14) r=jgraham,jonalmeida

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44012 for changes under testing/web-platform/tests

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/18ac798fd299

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Do we have a follow-up bug for the AGP bump?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #11)

https://hg.mozilla.org/mozilla-central/rev/18ac798fd299

This should have landed under bug 1873876. Reopening.

Comment 14

[Mihai Adrian Carare [:mcarare]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #12)

No. Not sure of the timeline, if we would do it after the migration or not, or along with the Firefox upgrade.

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Chris Peterson [:cpeterson]]

The Android team has not been keeping our P1 bug list up to date, so we're resetting all our P1 bugs to P2 to avoid signalling that we're actively working on bugs that we're not. The BMO documentation https://wiki.mozilla.org/BMO/UserGuide/BugFields#priority says P1 means "fix in the current release cycle" and P2 means "fix in the next release cycle or the following (nightly + 1 or nightly + 2)".

If you are actively working on this bug and expect to ship it in Fx 122 or 123, then please restore the priority back to P1.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d11b6847668
Upgrade Gradle to 8.5 version r=geckoview-reviewers,calu

Comment 18

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2d11b6847668

Comment 19

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1873677 - Compare availableHeightToTop and availableHeightToBottom when positioning menu.

When the popup doesn't fit up or down, because both availableHeightToTop and availableHeightToBottom are both smaller than containerHeight choose the highest one to choose menu direction.

Comment 20

[Phabricator Automation]

Comment on attachment 9392272 [details]
Bug 1873677 - Compare availableHeightToTop and availableHeightToBottom when positioning menu.

Revision D205207 was moved to bug 1854131. Setting attachment 9392272 [details] to obsolete.