1874986 - Editorial fixups to WPT client-props-zoom.html

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task)

Description

[Daniel Holbert [:dholbert]]

Attachment: image.png

When looking at bug 1874871, I noticed that the WPT in question (client-props-zoom.html) has a handful of cosmetic/correctness issues. See screenshot of test rendering (left) and source (right).

Cosmetic issues:

• Test rendering starts with a random " (from the end of line 5)
• test results are all highly-wrapped/overlapped making them unreadable
• test results are black text on dark blue background making them unreadable

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1874986: Fixups for nits/cosmetic issues in WPT client-props-zoom.html. r?#layout

This patch doesn't change the behavior (or pass/fail status) of the test at
all; it's just fixing some issues in the test that trigger parser errors and/or
make the test results hard to read.

Overview of the fixes:

• Removing a stray quote character (near the start) and a stray comma (in the
  middle of an element's attribute list).
• Wrapping the test content in an element that we can use to scope the rules,
  so that we don't end up with a generic 'div' css selector that inadvertently
  targets the test-results divs that the harness appends to the page.
• Removing the 'head' element since it's unnecessary and was being opened later
  than appropriate (after head content had already begun).
• Changing a background color from blue to cyan so that black text remains
  readable.
• Adding a newline at the end of the file.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d3e24654ca3
Fixups for nits/cosmetic issues in WPT client-props-zoom.html. r=TYLin

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44032 for changes under testing/web-platform/tests

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1d3e24654ca3

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: Bug 1874986: Fixups for nits/cosmetic issues in WPT getClientRects-zoom.html. r?TYLin

This patch doesn't change the behavior (or pass/fail status) of the test at
all; it's just fixing some issues in the test that trigger parser errors and/or
make the test results hard to read.

(This is very similar to the patch that I landed earlier in
https://bugzilla.mozilla.org/show_bug.cgi?id=1874986 ; this one's just for
a different test that had similar issues.)

Specific fixes here:

• Removing the 'head' element since it's unnecessary and was being opened later
  than appropriate (after head content had already begun).
• Wrapping the test content in an element that we can use to scope the rules,
  so that we don't end up with a generic 'div' css selector that inadvertently
  targets the test-results divs that the harness appends to the page.
• Remove a stray backtick at the end of the file, and add a final newline.
• Indentation changes to remove unnecessary indentation and to accommodate the
  newly-added "test_content" wrapper div.

Comment 6

[Phabricator Automation]

Comment on attachment 9373414 [details]
Bug 1874986: Fixups for nits/cosmetic issues in WPT getClientRects-zoom.html. r?TYLin

Revision D198906 was moved to bug 1875189. Setting attachment 9373414 [details] to obsolete.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot