Closed Bug 1875357 Opened 10 months ago Closed 10 months ago

Highlight drop down in-content needs carot to point up to indicate close

Categories

(Firefox :: PDF Viewer, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
124 Branch

People

(Reporter: rcasey, Assigned: calixte)

References

Details

Attachments

(3 files)

Attach (recommended) or Link to PDF file here:

Steps to reproduce the problem:

  1. Open Firefox
  2. Open a pdf such as https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf
  3. Select the highlight tool
  4. Create a highlight in the document (text or free form)
  5. Select the in-content highlight color drop down, select a different color
  6. Close the highlight color dropdown

What is the expected behavior? (add screenshot)
Clicking outside the panel doesnt automatically close the drop-down. There is no visual affordance of how to close the highlight color dropdown.

What went wrong? (add screenshot)
I think we should change the state of the carot to point upward, to give affordance to the user that they need to click on that button to close the dropdown. I've updated the figma accordingly: https://www.figma.com/file/elSBKpUxHCZe6yTqoohUu9/PDF.js-Designs?type=design&node-id=4744%3A132861&mode=design&t=018vZ6Wi4a4TfsPR-1

Flags: needinfo?(cdenizet)
Attached file example of updated UI
Assignee: nobody → rcasey
Assignee: rcasey → cdenizet
Status: NEW → ASSIGNED
Flags: needinfo?(cdenizet)
No longer depends on: 1876341
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: