1875773 - Add command line argument to allow overriding of default crash reporter behavior

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

By default geckodriver turns off the crash reporter so it doesn't interfere with application shutdown. This is done by setting the following environment variables:

• MOZ_CRASHREPORTER="1"
• MOZ_CRASHREPORTER_NO_REPORT="1"
• MOZ_CRASHREPORTER_SHUTDOWN="1"

Given that in some cases users aren't able to retrieve the crash report it would be good to have a command line argument that disables setting these env variables for both desktop and mobile. Then it can be used to investigate crash scenarios related to Firefox.

My proposal would be an argument like --enable-crash-reporter.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hello Razvan, given your interest in contributing Rust code and as well learning more about this language I think that this bug should be a good one for you. It would also help some of our users to actually send crash reports in cases when they cannot fetch the minidump files on their own. Let me know if you have interest. Thanks.

Comment 2

[Razvan Cojocaru]

Attachment: Bug 1875773 - [geckodriver] Add command line argument to enable crash reporter for diagnostic purposes. r?whimboo

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi Gabriele, please note that we want to add an option for geckodriver users to enable the crash reporter in situations when automation cannot easily export the minidump files. I wonder if we should maybe add a Remote Protocol tag or similar to the .extra file to let crash-stats know that this report is coming from automation. What do you think? Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77e120d25c7d
[geckodriver] Add command line argument to enable crash reporter for diagnostic purposes. r=whimboo,webdriver-reviewers

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/77e120d25c7d

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Razvan, thanks a lot for this new feature which we will ship with 0.35.0. Lets see if it will be already helpful for https://github.com/mozilla/geckodriver/issues/2153 to identify the crash details.

If you are interested in another bug to work on and you cannot find one just let me know.

Comment 7

[Razvan Cojocaru]

Happy to help! I've taken a shot at bug 1877649 also.

Feel free to add me to the CC of any bug you think I might be able to help with, and I'll receive an email notice and do my best to help if I can. Thanks!

Comment 8

[Gabriele Svelto [:gsvelto]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #3)

Hi Gabriele, please note that we want to add an option for geckodriver users to enable the crash reporter in situations when automation cannot easily export the minidump files. I wonder if we should maybe add a Remote Protocol tag or similar to the .extra file to let crash-stats know that this report is coming from automation. What do you think? Thanks!

I think that's a very good idea. We already have something similar for how the crash was submitted (see the SubmittedFrom crash annotation). You can either add to that if automation submits the crash reports on its own or add a new annotation specifically to say that it was generated in automation (but submitted using one of the existing mechanisms).

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks. I filed bug 1880257 as a follow-up for the crash annotation.