1877196 - Move more ASRouter modules to browser/components/asrouter

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1868838, I missed a few modules:

• Spotlight: "resource://activity-stream/lib/Spotlight.jsm"
• ToastNotification: "resource://activity-stream/lib/ToastNotification.jsm"
• ToolbarBadgeHub: "resource://activity-stream/lib/ToolbarBadgeHub.jsm"
• ToolbarPanelHub: "resource://activity-stream/lib/ToolbarPanelHub.jsm"
• MomentsPageHub: "resource://activity-stream/lib/MomentsPageHub.jsm"
• InfoBar: "resource://activity-stream/lib/InfoBar.jsm"
• ActorConstants: "resource://activity-stream/common/ActorConstants.sys.mjs" (see this comment)
• InflightAssetsMessageProvider: "resource://testing-common/InflightAssetsMessageProvider.sys.mjs" (see this comment)

If I discover more, I'll update the above list.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

All of the browser_asrouter tests under browser/components/newtab/test/browser also need to be moved.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move Spotlight.sys.mjs to browser/components/asrouter. r?pdahiya!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move ToastNotification.sys.mjs to browser/components/asrouter. r?pdahiya!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move ToolbarBadgeHub.jsm to browser/components/asrouter. r?pdahiya!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r?pdahiya!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move MomentsPageHub.sys.mjs to browser/components/asrouter. r?pdahiya!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move InfoBar.sys.mjs to browser/components/asrouter. r?pdahiya!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move InflightAssetsMessageProvider.sys.mjs to browser/components/asrouter. r?pdahiya!

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move browser_asrouter tests to browser/components/asrouter. r?pdahiya!

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r?pdahiya!

We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Comment 12

[Shane Hughes [:aminomancer]]

I think the following modules in newtab/lib should be in the asrouter or aboutwelcome directory:

FeatureCalloutBroker.sys.mjs
FeatureCalloutMessages.sys.mjs
PageEventManager.sys.mjs

We can also move FeatureCallout.sys.mjs from browser/modules to asrouter now. The reason we put it there previously was because we didn't want to add more stuff to the newtab directory that had nothing to do with newtab. But now that we have our own directories, it makes sense to keep all the Feature Callout files together.

We can move styles from browser/components/newtab/content-src/styles to asrouter as well:

_feature-callout-theme.scss
_feature-callout.scss
_shopping.scss

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move FeatureCallout modules and styles to browser/components/asrouter. r?pdahiya!

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877196 - Move PageEventManager.sys.mjs to browser/components/asrouter. r?pdahiya!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7e0311ce3a3
Move Spotlight.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/41e516a4f474
Move ToastNotification.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/a2a5866599fd
Move ToolbarBadgeHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/c88a794e2c4a
Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/3a82add91978
Move MomentsPageHub.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/212cdeb74d29
Move InfoBar.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/8264fa2061de
Move InflightAssetsMessageProvider.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/7e7b0e89be14
Move browser_asrouter tests to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/6d8e81032058
Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/575a584147b1
Move FeatureCallout modules and styles to browser/components/asrouter. r=fxview-reviewers,omc-reviewers,sclements,aminomancer
https://hg.mozilla.org/integration/autoland/rev/885e7a23a077
Move PageEventManager.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers,aminomancer

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d7e0311ce3a3
https://hg.mozilla.org/mozilla-central/rev/41e516a4f474
https://hg.mozilla.org/mozilla-central/rev/a2a5866599fd
https://hg.mozilla.org/mozilla-central/rev/c88a794e2c4a
https://hg.mozilla.org/mozilla-central/rev/3a82add91978
https://hg.mozilla.org/mozilla-central/rev/212cdeb74d29
https://hg.mozilla.org/mozilla-central/rev/8264fa2061de
https://hg.mozilla.org/mozilla-central/rev/7e7b0e89be14
https://hg.mozilla.org/mozilla-central/rev/6d8e81032058
https://hg.mozilla.org/mozilla-central/rev/575a584147b1
https://hg.mozilla.org/mozilla-central/rev/885e7a23a077

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d7e0311ce3a3
https://hg.mozilla.org/mozilla-central/rev/41e516a4f474
https://hg.mozilla.org/mozilla-central/rev/a2a5866599fd
https://hg.mozilla.org/mozilla-central/rev/c88a794e2c4a
https://hg.mozilla.org/mozilla-central/rev/3a82add91978
https://hg.mozilla.org/mozilla-central/rev/212cdeb74d29
https://hg.mozilla.org/mozilla-central/rev/8264fa2061de
https://hg.mozilla.org/mozilla-central/rev/7e7b0e89be14
https://hg.mozilla.org/mozilla-central/rev/6d8e81032058
https://hg.mozilla.org/mozilla-central/rev/575a584147b1
https://hg.mozilla.org/mozilla-central/rev/885e7a23a077

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d7e0311ce3a3
https://hg.mozilla.org/mozilla-central/rev/41e516a4f474
https://hg.mozilla.org/mozilla-central/rev/a2a5866599fd
https://hg.mozilla.org/mozilla-central/rev/c88a794e2c4a
https://hg.mozilla.org/mozilla-central/rev/3a82add91978
https://hg.mozilla.org/mozilla-central/rev/212cdeb74d29
https://hg.mozilla.org/mozilla-central/rev/8264fa2061de
https://hg.mozilla.org/mozilla-central/rev/7e7b0e89be14
https://hg.mozilla.org/mozilla-central/rev/6d8e81032058
https://hg.mozilla.org/mozilla-central/rev/575a584147b1
https://hg.mozilla.org/mozilla-central/rev/885e7a23a077