Closed Bug 1878161 Opened 9 months ago Closed 9 months ago

Move messaging surface code to asrouter directory

Categories

(Firefox :: Messaging System, task)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1877196

People

(Reporter: aminomancer, Unassigned)

References

(Blocks 1 open bug)

Details

I think the following modules in newtab/lib should be in the asrouter or aboutwelcome directory:

FeatureCalloutBroker.sys.mjs
FeatureCalloutMessages.sys.mjs
MomentsPageHub.jsm
PageEventManager.sys.mjs
Spotlight.jsm
ToastNotification.jsm
ToolbarBadgeHub.jsm
ToolbarPanelHub.jsm

We can also move FeatureCallout.sys.mjs from browser/modules to asrouter now. The reason we put it there previously was because we didn't want to add more stuff to the newtab directory that had nothing to do with newtab. But now that we have our own directories, it makes sense to keep all the Feature Callout files together.

We can move styles from browser/components/newtab/content-src/styles to asrouter as well:

_feature-callout-theme.scss
_feature-callout.scss
_shopping.scss
Status: NEW → RESOLVED
Closed: 9 months ago
Duplicate of bug: 1877196
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.