1877202 - Consider moving ModalOverlay back into browser/components/newtab

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1868838, ModalOverlay was moved from browser/components/newtab to browser/components/asrouter because it lived in browser/components/newtab/content-src/asrouter/components.

pdahiya pointed out in https://phabricator.services.mozilla.com/D198881#inline-1107881 that despite this, ModalOverlay is only actually used by newtab, and so it might actually make sense to move back.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1877202 - Move ModalOverlay back over to browser/components/newtab. r?thecount!

This originally got moved as part of bug 1868838 because it was under
browser/components/newtab/content-src/asrouter/components - however,
pdahiya points out that this component was actually only ever used
by newtab, so it makes more sense living over there.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cef992e837d1
Move ModalOverlay back over to browser/components/newtab. r=thecount

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cef992e837d1