1881106 - ModalOverlay.test.jsx is in the wrong directory (asrouter, should be in newtab)

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

ModalOverlay.test.jsx is in browser/components/asrouter/tests/unit, but I think it should be in browser/components/newtab/test/unit/content-src/components, to correspond to the location of the file it's testing, ModalOverlay.jsx. Consequently, the import path in the test file seems incorrect, it's not navigating back to the newtab directory, and there's no file at the specified path, so the import can't resolve.

Edit: From the hg history it looks like the component was moved to newtab in bug 1877202, but the test file was left in asrouter.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=#omc-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1877202

Comment 3

[Dianna Smith [:diannaS]]

:aminomancer any update on landing this? wondering if we are targeting 124 before early beta (EOW).

Comment 4

[Shane Hughes [:aminomancer]]

(In reply to Dianna Smith [:diannaS] from comment #3)

:aminomancer any update on landing this? wondering if we are targeting 124 before early beta (EOW).

We are landing it in 125.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149f61eecb69
Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/149f61eecb69