1877753 - Disable DefaultURI for unknown schemes

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[edgul]

Despite being spec compliant Bug 1603699 has caused significant unexpected regression. This bug aims to revert to nsSimpleURI for fallback.

Comment 1

[edgul]

Attachment: Bug 1877753 - Disable DefaultURI for unknown schemes. r?valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f84c76f9460d
Disable DefaultURI for unknown schemes. r=valentin,necko-reviewers

Comment 3

[edgul]

Comment on attachment 9377468 [details]
Bug 1877753 - Disable DefaultURI for unknown schemes. r?valentin

Beta/Release Uplift Approval Request

• User impact if declined: Users will continue to experience problems with accessing their thirdparty services using protocol handlers via the address bar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The main change is just flipping a pref that will revert to previous (working) behavior. Other changes are only tests.
• String changes made/needed: No
• Is Android affected?: Yes

Comment 4

[edgul]

Cancelled uplift request. Need to re-land this

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c55dfe47188
Backed out changeset f84c76f9460d as requested for a typo mistake.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16cadb9ec0b
Disable DefaultURI for unknown schemes. r=valentin,necko-reviewers

Comment 7

[Cristina Horotan [:chorotan]]

Backed out changeset f84c76f9460d (bug 1877753) as requested for a typo mistake.

Backout: https://hg.mozilla.org/integration/autoland/rev/6c55dfe47188d65cd4a24b3f26a8d00a3c8d46ac

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f84c76f9460d8a2a4048954be483e24638c0f39c

Comment 8

[edgul]

Comment on attachment 9377468 [details]
Bug 1877753 - Disable DefaultURI for unknown schemes. r?valentin

Beta/Release Uplift Approval Request

• User impact if declined: Users will continue to experience problems with accessing their thirdparty services using protocol handlers via the address bar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, because it is just a pref flip back to previous (working) behavior. Other changes are just test fixes for expectations.
• String changes made/needed: no
• Is Android affected?: Yes

Comment 9

[edgul]

Note: Patch in comment 6 addresses reason for backout in comment 7

Comment 10

[Atila Butkovits]

Backed out for causing failures at non-special-url-getter-setter.window.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f3cb1339e20d8b5ecf1c37615d78a2ba33139cb6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=IhgbrrzGRuu02KKshoLYfQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f16cadb9ec0bb2aa16f91092af121e6e14b32091

Failure log: https://treeherder.mozilla.org/logviewer?job_id=445608243&repo=autoland&lineNumber=13572

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/234e0c8fc61f
Disable DefaultURI for unknown schemes. r=valentin,necko-reviewers

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/234e0c8fc61f

Comment 13

[Tom Schuster]

[Tracking Requested - why for this release]: This was originally being tracked in bug 1877012.

Comment 14

[edgul]

Should be no change to beta/release uplift request in comment 8, I don't need to re-request due to the backout/fix right?

Comment 15

[Donal Meehan [:dmeehan]]

(In reply to Ed Guloien [:edgul] from comment #14)

Should be no change to beta/release uplift request in comment 8, I don't need to re-request due to the backout/fix right?

Correct, no change is needed to the beta/release uplift requests.
This is already on relmans radar to uplift to beta and release.

Comment 16

[Pascal Chevrel:pascalc]

Comment on attachment 9377468 [details]
Bug 1877753 - Disable DefaultURI for unknown schemes. r?valentin

Approved for 123 beta 7, thanks.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d12904fe6c88

Comment 18

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d12904fe6c88

Comment 19

[Donal Meehan [:dmeehan]]

Comment on attachment 9377468 [details]
Bug 1877753 - Disable DefaultURI for unknown schemes. r?valentin

Approved for 122.0.1

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7fa6ab6827f4