Closed Bug 1877826 Opened 4 months ago Closed 1 month ago

Add MozPageNavLink custom component to MozPageNav

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: kcochrane, Assigned: kcochrane)

References

(Blocks 4 open bugs, Regressed 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file)

Adding this as a follow-up to bug 1850591. The new moz-page-nav component will be implemented for Firefox View first where no support link is needed, so we've decided to break out the work to add moz-page-nav-link as a component separately from the rest of moz-page-nav. We should make use of moz-support-link for moz-page-nav-link if possible. It will need to support launching to support pages as well as external links.

See this doc for more information.

Blocks: 1867385
Blocks: 1881767

I was doing a bit of exploring around how much work would be involved in using moz-page-nav in a few new locations and put together a quick POC for how we could modify the existing moz-page-nav-button component to also support links: https://hg.mozilla.org/try/rev/1f9a88500edba81b18a1fa8e1df74a08cf406bc7

Something like that might be desirable as it gives us the option to use either links or buttons in both the footer and the main nav. Probably needs a bit of tweaking still (maybe moz-page-nav-item is a better name?), but could be a useful starting point.

Whiteboard: [recomp]
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Attachment #9396050 - Attachment description: WIP: Bug 1877826 - Add support for external and support links in moz-page-nav → Bug 1877826 - Add support for external and support links in moz-page-nav
Blocks: 1891095
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16e638312c10
Add support for external and support links in moz-page-nav r=desktop-theme-reviewers,reusable-components-reviewers,sfoster,hjones
Regressions: 1891644
See Also: → 1891644
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: