1877826 - Add MozPageNavLink custom component to MozPageNav

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Kelly Cochrane [:kcochrane]]

Adding this as a follow-up to bug 1850591. The new moz-page-nav component will be implemented for Firefox View first where no support link is needed, so we've decided to break out the work to add moz-page-nav-link as a component separately from the rest of moz-page-nav. We should make use of moz-support-link for moz-page-nav-link if possible. It will need to support launching to support pages as well as external links.

See this doc for more information.

Comment 1

[Hanna Jones [:hjones]]

I was doing a bit of exploring around how much work would be involved in using moz-page-nav in a few new locations and put together a quick POC for how we could modify the existing moz-page-nav-button component to also support links: https://hg.mozilla.org/try/rev/1f9a88500edba81b18a1fa8e1df74a08cf406bc7

Something like that might be desirable as it gives us the option to use either links or buttons in both the footer and the main nav. Probably needs a bit of tweaking still (maybe moz-page-nav-item is a better name?), but could be a useful starting point.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1877826 - Add support for external and support links in moz-page-nav

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16e638312c10
Add support for external and support links in moz-page-nav r=desktop-theme-reviewers,reusable-components-reviewers,sfoster,hjones

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/16e638312c10