1877995 - Unable to navigate with NVDA using Down arrow from the X Close button of the Review Checker Callouts v1.1

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 124.0a1 (2024-02-01)

Affected versions

• Nightly 124.0a1 (2024-02-01)
  ALL version where the user is Enrolled in the experiment.

Affected platforms

• All

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Set nimbus.debug to true
Set messaging-system.rsexperimentloader.collection_id to nimbus-preview
Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
security.ssl.enable_ocsp_stapling - False

Reach the following link:
about:studies?optin_slug=review-checker-callouts-v11-experiment&optin_branch=treatment-a&optin_collection=nimbus-preview

ENABLE NVDA

Steps to reproduce

1. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
2. Close the Review Checker from the X Close button.
3. Reach the X Close button from the Callout using Keyboard navigation.
4. Hit The Down Arrow in order to Read the Callout content using NVDA.

Expected result

• The user should be able to Reach the Text from the Callous with NVDA using the Down Arrow while on the X Close button.

Actual result

• Hitting the Down arrow on the keyboard will keep NVDA blocked on the X Close button.

• Hitting UP arrow from the Dissmis button will allow NVDA to reach the Text from the Callout without issues.

Regression range
Not a Regression

Please also note that this issue occurs on CALLOUT 1, CALLOUT 2 as well as CALLOUT 3.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1877995 - Move feature callout dismiss button so the tab order makes more sense. r=#omc-reviewers

Comment 2

[Anna Yeddi [:ayeddi]]

It appears that the Close button is placed at the end of the document, thus Down arrow won't read anything - there is nothing after it in the DOM for the A11y tree to read. Since the button is visually appears at the top right corner of the dialog, moving x at the top of the dialog's DOM should resolve all issues and fix keyboard and screen reader issues now and in the future too

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fbc51810324
Move feature callout dismiss button so the tab order makes more sense. r=omc-reviewers,negin

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4fbc51810324

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 124.0a1 (2024-02-14) .

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Rares Doghi, Desktop QA]

Updating the main status flag.