1878008 - Make the feature callout panel unfocusable (remove tabIndex)

Status: NEW

(Firefox :: Messaging System, enhancement, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: Keyboards.mp4

Found in

• Nightly 124.0a1 (2024-02-01)

Affected versions

• Nightly 124.0a1 (2024-02-01)
  ALL version where the user is Enrolled in the experiment.

Affected platforms

• All

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Set nimbus.debug to true
Set messaging-system.rsexperimentloader.collection_id to nimbus-preview
Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
security.ssl.enable_ocsp_stapling - False

Reach the following link:
about:studies?optin_slug=review-checker-callouts-v11-experiment&optin_branch=treatment-a&optin_collection=nimbus-preview

Steps to reproduce

1. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
2. Close the Review Checker from the X Close button.
3. Use the Tab key in order to navigate inside the Callout.
4. Use Shift + Tab keys in order to navigate backwards inside the Callout.

Expected result

• Navigating inside each Callout v1.1 with Shift+Tab should only reach the buttons.

Actual result

• Navigating inside each Callout v1.1 with Shift+Tab will also reach the Panel itself.

• Navigating inside of each Callout v1.1 with Tab only will not reproduce this issue.

Regression range
Not a Regression

Please note that this issue occurs on all 3 CALLOUTS v1.1

Comment 1

[Shane Hughes [:aminomancer]]

Focusing the panel was the intended behavior since feature callout was first implemented, since the Escape key closes the callout. Later on we made it focus the first available button instead, but left the panel focusable. Idk if we still want it to be focusable, but it's not a blocker for the RC experiment. It's just a design question for the generic feature callout template.

Venetia - I'm wondering if you have an opinion about whether the callout container should still be focusable, since you argued against it in bug 1790848. If you don't like it, we can get rid of it in 124.

Comment 2

[Rares Doghi, Desktop QA]

Should it also be focusable when we use just the Tab key? because its only focusable if we reach it with Shift+Tab. @Shane

Comment 3

[Shane Hughes [:aminomancer]]

(In reply to Rares Doghi, Desktop QA from comment #2)

Should it also be focusable when we use just the Tab key? because its only focusable if we reach it with Shift+Tab. @Shane

It's a difficult question. When we originally designed Feature Callout, it wasn't a panel, it was a popup inside the Firefox View content page. So it had its own focus behavior. But with Firefox 119, we started putting feature callouts in panels in the browser chrome, and at that point they became subject to the normal tab focus rules for panels. It's normal Firefox behavior for focus to get "stuck" within the panel, and to not be able to reach the panel with Tab. But for some reason it's still allowed to reach the panel on Shift+Tab. I think it would be normal for the panel to just be unfocusable.

Whatever we decide, it requires some code changes. I see this as a relatively minor issue not blocking the experiment, but there's definitely a defect. There are 2 options from here:

1. Make the panel unfocusable, like other panels
2. Make the panel focusable with both Tab and Shift+Tab (right now it's only focusable with Shift+Tab)

Comment 4

[Vtay]

After chatting with Shane, I would prefer the panel to be unfocusable