1878149 - Failing WPTs IndexedDB/structured-clone.any[.worker].html

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Thomas Wisniewski [:twisniewski][PTO until the 26th]]

See:

• https://wpt.fyi/results/IndexedDB/structured-clone.any.html%253F101-last
• https://wpt.fyi/results/IndexedDB/structured-clone.any.worker.html%253F101-last

it looks as though we aren't serializing FireList or Symbol objects.

Comment 1

[Jens Stutte [:jstutte]]

(In reply to Thomas Wisniewski [:twisniewski] from comment #0)

See:

• https://wpt.fyi/results/IndexedDB/structured-clone.any.html%253F101-last
• https://wpt.fyi/results/IndexedDB/structured-clone.any.worker.html%253F101-last

it looks as though we aren't serializing FireList or Symbol objects.

It seems since May 1st we pass the symbol sub-test, too, only FileList is still failing. Do we know what fixed this?

Comment 2

[Thomas Wisniewski [:twisniewski][PTO until the 26th]]

Bug 1893807 is where we changed the test-expectation.

Unexpectedly, mozregression tells me that it was my own patch in bug 1878148 which may have fixed it.. I'm not sure how, though. Since it's an intermittent failure I wouldn't be surprised if it didn't actually fix it.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Yeah, we don't see to have tags for it in the JS engine or in DOM plus the JS logic only seems to mention the token "symbol" to skip them.

Comment 4

[Jari Jalkanen [:jari]]

The test is expecting a data clone error. Apparently, we were previously throwing some other error which got supressed and rethrown as the spec compliant error thanks to the SharedArrayBuffer case fix.

Maybe it would be good to double check that we get the correct error also in the case when Symbol is not the only thing that we are trying to clone (it might complain about missing data), i.e when it would get skipped but some valid data still remains.

Comment 5

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Add Filelist structured cloning support to IDB. r=#dom-storage

Comment 6

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Avoid transaction complete event race condition. r=smaug

Comment 7

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Expect blob to not time out in structured-clone.any.js test. r=smaug

Comment 8

[Jari Jalkanen [:jari]]

Attachment: WIP: Bug 1878149 - Incremental progress related to FileList serialization.

*** NOT MEANT FOR REVIEWING EYES ***

Comment 9

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Use Rooted JSObject for structured clone read callback return value. r=sfink

Comment 10

[Phabricator Automation]

Comment on attachment 9426767 [details]
Bug 1878149 - Avoid transaction complete event race condition. r=smaug

Revision D223304 was moved to bug 1920989. Setting attachment 9426767 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9426768 [details]
Bug 1878149 - Expect blob to not time out in structured-clone.any.js test. r=smaug

Revision D223305 was moved to bug 1920989. Setting attachment 9426768 [details] to obsolete.

Comment 12

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Add async version of verifyBlob to file.js helper for IDB. r=#dom-storage

Comment 13

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Test deserialization function with filelist for IDB schema upgrades. r=#dom-storage

Comment 14

[Jari Jalkanen [:jari]]

Attachment: Bug 1878149 - Test indexing of data containing a filelist for IDB. r=#dom-storage

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/800ae4bac0c2
Add async version of verifyBlob to file.js helper for IDB. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/dbe05e5bf71e
Add Filelist structured cloning support to IDB. r=dom-storage-reviewers,janv,asuth
https://hg.mozilla.org/integration/autoland/rev/bba88b082421
Test deserialization function with filelist for IDB schema upgrades. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3944ec7fc0eb
Test indexing of data containing a filelist for IDB. r=dom-storage-reviewers,janv

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/800ae4bac0c2
https://hg.mozilla.org/mozilla-central/rev/dbe05e5bf71e
https://hg.mozilla.org/mozilla-central/rev/bba88b082421
https://hg.mozilla.org/mozilla-central/rev/3944ec7fc0eb