Open Bug 1878430 Opened 1 year ago Updated 2 months ago

Lando keeps saying "The warnings present when the request was constructed have changed", doesn't allow me to land the patch

Categories

(Conduit :: Lando, defect)

Product:
Conduit
Component:
Lando
Type:
defect

Tracking

(Not tracked)

People

(Reporter: botond, Unassigned)

References

Details

I'm trying to land https://lando.services.mozilla.com/D200422/. There are 12 warnings, which I have to check (which, by the way, is itself annoying; can we add a "check all" button?), and once I've done that, I get an error saying:

Landing Failed
The warnings present when the request was constructed have changed. Please acknowledge the new warnings and try again.

I go to "Preview Landing" again, but the set of warnings seems to be exactly the same as before. After I check all 12 of them again, I just get the same error.

Worked around for now by rebasing the patch series locally and resubmitting, which fixed some / enough of the warnings to not trigger this scenario.

See Also: → 1833096

This happened more than once to me in the past few days, and after a few retries it eventually goes through. But importantly, nothing happened to the patches between those retries.

I could be wrong but it looks like the number of retries depends on the number of patches.

Can you share which warnings were present that you had to re-confirm? Wondering if these are static warnings, or possibly ones that are related to review bot, or if there is another pattern in this behaviour.

Flags: needinfo?(mh+mozilla)

Usually when that happens it's the static analysis warnings ones. Last time was static analysis and one of the patches not being approved (because herald would keep reading a blocking group review that was kind of bogus)

Flags: needinfo?(mh+mozilla)

This is happening again trying to land bug 1902571.

:ajakobi has run into this as well trying to land bug 1841896.

This bug is pretty frustrating because it forces you to pull and check out latest m-c in order to land your patch, resulting in a lot of file modifications and a long rebuild.

See Also: → 1925062

Happened to me as well for https://lando.services.mozilla.com/D234702/. There are a lot of warnings like those:

Static analysis and linting are still in progress. [D234702]
Static analysis and linting did not run due to failure in applying the patch. [D234702]
You need to log in before you can comment on or make changes to this bug.