Closed
Bug 1878457
Opened 2 years ago
Closed 2 years ago
ESMify performance-new modules
Categories
(DevTools :: Performance Tools (Profiler/Timeline), task)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox124 fixed)
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
(Whiteboard: [esmification-timeline])
Attachments
(3 files)
Those modules had been overlooked by the are-we-esmified-yet script because they've been using .jsm.js extension and indirect var EXPORTED_SYMBOLS = Object.keys(module.exports); syntax, which doesn't match the pattern.
so far I don't see anything blocks converting them to ESM, so I'll give it a try and submit patches once I confirmed fix.
| Assignee | ||
Updated•2 years ago
|
Whiteboard: [esmification-timeline]
| Assignee | ||
Comment 1•2 years ago
|
||
| Assignee | ||
Comment 2•2 years ago
|
||
| Assignee | ||
Comment 3•2 years ago
|
||
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/c2b811f0f8d8
Part 1: ESMify performance-new modules. r=julienw,profiler-reviewers
https://hg.mozilla.org/integration/autoland/rev/247e7e28d7cc
Part 2: ESMify consumers of performance-new modules. r=julienw,profiler-reviewers
https://hg.mozilla.org/integration/autoland/rev/9f16b642b137
Part 3: Remove JSM section from performance-new README. r=julienw,profiler-reviewers
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c2b811f0f8d8
https://hg.mozilla.org/mozilla-central/rev/247e7e28d7cc
https://hg.mozilla.org/mozilla-central/rev/9f16b642b137
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Comment 6•2 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•