1878512 - Bump TypeScript version to make it compatible with .mjs extension

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task)

Description

[Tooru Fujisawa [:arai]]

Bug 1878457 is to ESMify performance-new modules, which is using .jsm.js extension right now due to TypeScript compatibility.
system ESM wants to use .sys.mjs, but typescript 4.3.5 (package.json) doesn't seem to support .mjs extension.

Bumping the version to 5.3.3 seem to solve the extension issue, but it causes some compatibility issue (see bug 1878467 comments).
So those code needs to be tweaked before bumping the version.

I'm not actively using typescript, and I'm not sure the consequence of bumping typescript versions, so let me know if there's any constraint.

Comment 1

[Tooru Fujisawa [:arai]]

According to https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html , .mjs support was added from 4.7.
So, minimum requirement for bug 1878457 with .sys.mjs would be 4.7.

Then, 4.7 throws the same set of errors as 5.3.3 (see bug 1878467 comment #4), which is the try-catch's error type and the template base type.
So, in term of compatibility issue around type check itself, the amount of change is same between "bump to 5.3.3" vs "bump to 4.7".

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1878512 - Part 1: Make error handling explicit about the type. r?julienw!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1878512 - Part 2: Add explicit base type for template parameter. r?julienw!

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1878512 - Part 3: Bump TypeScript version for performance-new to 5.3.3. r?julienw!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e560e2db4ea
Part 1: Make error handling explicit about the type. r=julienw,profiler-reviewers
https://hg.mozilla.org/integration/autoland/rev/40dc05adc5ed
Part 2: Add explicit base type for  template parameter. r=julienw,profiler-reviewers
https://hg.mozilla.org/integration/autoland/rev/21a10db59ccf
Part 3: Bump TypeScript version for performance-new to 5.3.3. r=julienw,profiler-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6e560e2db4ea
https://hg.mozilla.org/mozilla-central/rev/40dc05adc5ed
https://hg.mozilla.org/mozilla-central/rev/21a10db59ccf

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6e560e2db4ea
https://hg.mozilla.org/mozilla-central/rev/40dc05adc5ed
https://hg.mozilla.org/mozilla-central/rev/21a10db59ccf