1878911 - Add the UI to enable FPP (aka 'Suspected Fingerprinters') in ETP Custom

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, enhancement)

Description

[Tom Ritter [:tjr]]

Desktop enables FPP outside PBM (where it is on by default, see Bug 1878407 to enable it on Android) by enabling it in ETP Strict. It also has the ability to enable it in PBM/All Windows in ETP Custom as a separate checkbox called 'Suspected Fingerprinters'.

This bug is about adding the same UI for ETP Custom for Fenix.

Comment 1

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Bug 1878911: Implement UI for ETP Custom. r?timhuang

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:fkilic, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Hmm, I don't have L3 access, so I can't land it. Though, at this point I think I have re-run the linter to add correct API changes, hash, and change string removed-in versions. I'll ask for someone to land it after I do those changes.

Comment 4

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

I rebased it and made appropriate changes. It should be good to land.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e05421032fc6
Implement UI for ETP Custom. r=tjr,android-reviewers,boek,geckoview-reviewers,amejiamarmol

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59cd95e63e42
Fix fenix lint failure CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/198fcb5b5631
Another fenix lint fix. CLOSED TREE

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing multiple fenix failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/560602918751a933ef548464fcac03a96214a12c

Push with failures

Failure log -> /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/res/values/strings.xml:1612: Error: The resource R.string.preference_enhanced_tracking_protection_custom_fingerprinters appears to be unused [UnusedResources]

Failure log -> fenix tests

Failure log -> /builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/res/values/strings.xml:1638: Error: The resource R.string.etp_fingerprinters_title appears to be unused [UnusedResources]

Comment 9

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Sorry, I wasn't aware of UI tests. They weren't using resource ids, so I couldn't find them by looking up references. Fixing it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2424995fe62
Implement UI for ETP Custom. r=tjr,android-reviewers,boek,geckoview-reviewers,amejiamarmol

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2424995fe62

Comment 12

[Mira Lobontiu (Android QA)]

Verified as implemented on the latest Fenix Nightly 131.0a1 from 8/8, and on Beta 130.0b2, with Xiaomi Mi8 Lite (Android 10), and Google Pixel 6 (Android 15).

Verified that:

• a new checkbox was implemented in the Enhanced Tracking Protection - "Custom" area, named Suspected Fingerprinters --> enables CanvasRandomization protection, but not Font pack protection on Android (based on https://searchfox.org/mozilla-central/source/toolkit/components/resistfingerprinting/RFPTargetsDefault.inc), and
• the "Fingerprinters" option was renamed "Known Fingerprinters".

Comment 13

[Dianna Smith [:diannaS]]

:fkilic did you want to include this in the fx131 release notes? (Release_Notes_Nomination)

Comment 14

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Sure, that would be awesome. Thank you!

Comment 15

[Dianna Smith [:diannaS]]

great! Can you set the relnote-firefox: flag to "?" and add the attached Suggested wording/screesnhots (if applicable) for the fix. I can then ensure it makes it to release notes.

Comment 16

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Fullpage screenshot of enhanced tracking protection page in setting with custom option selected

Comment 17

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Attachment: Screenshot of enhanced tracking protection page in setting with Suspected Fingerprinters dropdown open

Comment 18

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

I'm not really sure about the wording. I looked at already existing texts and all I could really find is, Enables fingerprinting protection to stop suspected fingerprinters. My suggestion would be something like you can now enable protection against suspected fingerprinters to improve your privacy on mobile or depending on how technical the notes are, maybe something like "you can now manage privacy.fingerprintingProtection on mobile using custom and strict enhanced tracking protection options." one last option I can think of is, You can now enable protection against suspected fingerprinters using strict or custom enhanced tracking options. does any of this sound good or should I think of something else? Just as a note, this feature only affected Android, we basically matched the desktop firefox behaviour with android firefox.

Comment 19

[Dianna Smith [:diannaS]]

Added to fx131 release notes: https://www.mozilla.org/en-US/firefox/131.0beta/releasenotes/
Ill add the image as well shortly (it takes about 30 minutes to update)
You can now enable protection against suspected fingerprinters on Firefox for Android using custom and strict enhanced tracking protection options.

Comment 20

[Fatih Kilic [:fkilic] (OOO -> Aug 12)]

Awesome thank you so much! The images are not the most engaging images out there, so you can omit them if you think they don't fit/look good.