Closed Bug 1880477 Opened 2 months ago Closed 2 months ago

Implement basic support for "network.provideResponse" command

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
3

Tracking

(firefox124 fixed, firefox125 fixed)

RESOLVED FIXED
125 Branch
Tracking Status
firefox124 --- fixed
firefox125 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m10], [wptsync upstream])

Attachments

(4 files)

Implement only the mandatory request argument, same as what was done for Bug 1874206

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:m10]
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbe00a7052e5
[bidi] Add basic support for network.provideResponse command r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/3a2076959886
[wdspec] Add support for all provideResponse arguments in network test module r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/81f6e585b372
[wdspec] Add tests for invalid arguments for all provideResponse parameters r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/0104eaefd144
[wdspec] Add test for basic support of network.provideResponse r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44733 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m10] → [webdriver:m10], [wptsync upstream]
Upstream PR was closed without merging

Comment on attachment 9380416 [details]
Bug 1880477 - [bidi] Add basic support for network.provideResponse command

Beta/Release Uplift Approval Request

But we did not realize that we missed the command implemented by this bug. With this command available all commands for network interception have at least some basic support in our WebDriver BiDi implementation, which will make for a more consistent experience for clients if they want to start using network interception features.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch only impacts webdriver bidi users, and is a new feature.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9380416 - Flags: approval-mozilla-beta?
Attachment #9380418 - Flags: approval-mozilla-beta?
Attachment #9380419 - Flags: approval-mozilla-beta?
Attachment #9380420 - Flags: approval-mozilla-beta?
Upstream PR was closed without merging
Upstream PR was closed without merging
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot

Comment on attachment 9380416 [details]
Bug 1880477 - [bidi] Add basic support for network.provideResponse command

Approved for 124.0b4

Attachment #9380416 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9380418 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9380419 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9380420 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: