1880477 - Implement basic support for "network.provideResponse" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

Implement only the mandatory request argument, same as what was done for Bug 1874206

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1880477 - [bidi] Add basic support for network.provideResponse command

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1880477 - [wdspec] Add support for all provideResponse arguments in network test module

Depends on D201967

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1880477 - [wdspec] Add tests for invalid arguments for all provideResponse parameters

Depends on D201969

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1880477 - [wdspec] Add test for basic support of network.provideResponse

Depends on D201970

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbe00a7052e5
[bidi] Add basic support for network.provideResponse command r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/3a2076959886
[wdspec] Add support for all provideResponse arguments in network test module r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/81f6e585b372
[wdspec] Add tests for invalid arguments for all provideResponse parameters r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/0104eaefd144
[wdspec] Add test for basic support of network.provideResponse r=webdriver-reviewers,Sasha

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44733 for changes under testing/web-platform/tests

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cbe00a7052e5
https://hg.mozilla.org/mozilla-central/rev/3a2076959886
https://hg.mozilla.org/mozilla-central/rev/81f6e585b372
https://hg.mozilla.org/mozilla-central/rev/0104eaefd144

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 9380416 [details]
Bug 1880477 - [bidi] Add basic support for network.provideResponse command

Beta/Release Uplift Approval Request

• User impact if declined: For Firefox 124, we removed the experimental flag for network interception features in WebDriver BiDi in https://bugzilla.mozilla.org/show_bug.cgi?id=1845345

But we did not realize that we missed the command implemented by this bug. With this command available all commands for network interception have at least some basic support in our WebDriver BiDi implementation, which will make for a more consistent experience for clients if they want to start using network interception features.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only impacts webdriver bidi users, and is a new feature.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9380416 [details]
Bug 1880477 - [bidi] Add basic support for network.provideResponse command

Approved for 124.0b4

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e954ab86f291
https://hg.mozilla.org/releases/mozilla-beta/rev/98846427f147
https://hg.mozilla.org/releases/mozilla-beta/rev/846ab5e49080
https://hg.mozilla.org/releases/mozilla-beta/rev/a356ae52710f