1880550 - Table cells in workday.com are cut-off

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[David Durst [:ddurst]]

Attachment: image.png

Noticed in Nightly only that a table was cutting off cell content horizontally. Confirmed that setting layout.tables.scrollable-cells to false fixes it.

This may be the same as bug 1877719, but filing it in case.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 221154

:emilio, since you are the author of the regressor, bug 221154, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

It smells like it, but hard to say without being able to repro. All tables I could find at a glance looked fine for me, do you know how can I find a broken one?

Comment 3

[Daniel Holbert [:dholbert]]

I can reproduce this in Nightly on Ubuntu 22.04 in every workday table that I've tried so far.

From the "Personal Information" section (in workday hamburger menu at top-left), I can see this in nearly all of the View options:

• Personal Data - Data Portability
• Addresses
• Email Addresses
• Address Changes
• Name
• Phone Numbers

On a few of these pages, some fields are affected and some aren't. Also, it repros more-readily at some full-page-zoom levels more than others. (E.g. I see it at 100% and 80% but not others).

It's most obvious in the Name section since that one's got a giant "Edit" Button that's substantially clipped, at every zoom level that I've tried.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot of workday Name page with pref disabled (left, no bug) vs. enabled (right, bug)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case.

D'oh, my fault. I had the pref toggled to test something else.

Here's a minimal test-case.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

This is partially related to bug 1877719, but the vertical alignment stuff makes it slightly different... Let's keep it open for now.

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: reduced testcase 2

Here's a slightly-more-reduced testcase, in case it's valuable. This one is just illustrating that we honor the specified height on the td element with overflow:hidden; Chrome treats it as a suggestion and makes the td taller if the content-height is taller.

(The Chrome behavior makes overflow:hidden kind of useless in this context, unless the overflowing content is out-of-flow and doesn't contribute to the content height, I guess? Maybe that's what we need to do here as well?)

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 221154

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1880550 - Propagate explicit heights to scrolled table cells as min-heights. r=dholbert

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d83939746c70
Propagate explicit heights to scrolled table cells as min-heights. r=dholbert

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44700 for changes under testing/web-platform/tests

Comment 12

[Serban Stanca [:SerbanS]]

Backed out for causing reftests failures bug785684-x.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/table-overflow/bug785684-x.html == layout/reftests/table-overflow/bug785684-x-ref.html | image comparison, max difference: 54, number of differing pixels: 1656

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cdb37e233eb
Propagate explicit heights to scrolled table cells as min-heights. r=dholbert

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7cdb37e233eb

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using FF build 124.0a1(2024-02-15) using attached testcases from comments #5 #7.
Verified as fixed on Win11x64/Ubuntu 22.04/Mac 12.6 using FF builds 125.0b5 and 126.0a1.