<a class="header-button" href="https://bugzilla.mozilla.org/home" title="Go to home page"> Bugzilla

Reporter

Updated

•

9 months ago

Duplicate of this bug: 1875882

Reporter

Comment 2

•

9 months ago

eF7B08LURDqhM3fLxikRgQ

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=9ec5e40bb94dc8e597ec5ccb85324dde86427ad6

Reporter

Comment 3

•

9 months ago

Attached file Bug 1880814 - Update libvpx to 4340382bb0da7623ecd27c3bfc9e5bec576e9c46 (obsolete) — Details

Reporter

Comment 4

•

9 months ago

Attached file Bug 1880814 - Apply mozilla patches for libvpx (obsolete) — Details

Reporter

Comment 5

•

9 months ago

b6lu_a16SRSOaiCAzfCOLg

It looks like we experienced one or more build failures when trying to apply this
update. You will need to apply this update manually; you can replicate the patch
locally with ./mach vendor media/libvpx/moz.yaml. I'm going to abandon the Phabricator patch and
let you submit a new one.

If the build failure wasn't caused by a library change, and was instead caused by
something structural in the build system please let my maintainers know in
Slack:#secinf.

I do my best to automatically add new files to the build, but some moz.build files
are complicated and you may need to fix them manually.

Flags: needinfo?(cchang)

Updated

•

9 months ago

Attachment #9380812 - Attachment is obsolete: true

Updated

•

9 months ago

Attachment #9380813 - Attachment is obsolete: true

Assignee

Comment 6

•

9 months ago

There is a build failures when updating to the latest version: https://treeherder.mozilla.org/jobs?repo=try&revision=34e0cf5f033c36197fc2494be0359f64fbbf3e18&selectedTaskRun=cY7cnISiRT2A3gjrTXbmNQ.0

/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:36:10: error: 'svget_neonq_s64' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:36:26: error: 'svdot_s64' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:36:36: error: 'svset_neonq_s64' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:36:52: error: 'svundef_s64' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:37:36: error: 'svset_neonq_s16' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:37:52: error: 'svundef_s16' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:38:36: error: 'svset_neonq_s16' needs target feature sve
/builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/arm/dot_neon_sve_bridge.h:38:52: error: 'svundef_s16' needs target feature sve

I'll investigate the issue.

[1] https://chromium.googlesource.com/webm/libvpx/+/7fb8ceccf92c35cd5131b05c0502916715ebc76b/build/make/Android.mk#38
[2] https://chromium.googlesource.com/webm/libvpx/+/7fb8ceccf92c35cd5131b05c0502916715ebc76b/build/make/configure.sh#1262
[3] https://chromium.googlesource.com/webm/libvpx/+/7fb8ceccf92c35cd5131b05c0502916715ebc76b/build/make/rtcd.pl#525

Assignee

Comment 7

•

8 months ago

Attached file Bug 1880814 - Disable SVE on win/aarch64 — Details

This patch disables the SVE features on win/aarch64 platform.

According to libvpx setting scripts [1, 2], the sve feature in config
file can be disabled by adding --disable-sve option when running
the configure script.
According to rtcd.pl [3], the SVE-related function in headers
ending with _rtcd.h can be removed by --disable-sve option.

Assignee

Comment 8

•

8 months ago

Attached file Bug 1880814 - Logs for libvpx configuration on various platforms — Details

This patch generates log files during the configuration of libvpx on
variouse platforms. These logs can be used for manual verification of
the correctness of settings. In this particular case, the log file for
win/aarch64 reveals the sve feature is disabled on win/aarch64.

The logs will be excluded to the repo, by .gitignore settings.

Depends on D204798

[1] https://chromium.googlesource.com/webm/libvpx/+/7fb8ceccf92c35cd5131b05c0502916715ebc76b/build/make/Makefile#151

Assignee

Comment 9

•

8 months ago

Attached file Bug 1880814 - Port the cflags from Makefile to moz.build — Details

The cflags for sve features are introduced on arm platforms in this
patch. These settings are brought from libvpx's Makefile.

Depends on D204799

Assignee

Comment 10

•

8 months ago

Attached file Bug 1880814 - Remove files ending with *_sve.c* on win/aarch64 — Details

This patch removes the sve-related files from libvpx sources on Windows
AArch64 platforms. The SVE-feature was disabled on the previous patch.

Depends on D204800

Assignee

Comment 11

•

8 months ago

Attached file Bug 1880814 - Update libvpx to 7fb8ceccf92c35cd5131b05c0502916715ebc76b — Details

This patch runs

./mach vendor media/libvpx/moz.yaml --patch-mode=none

to update libvpx to 7fb8cec

Depends on D204801

Assignee

Comment 12

•

8 months ago

Attached file Bug 1880814 - Adjust input_frame_validation.patch — Details

The input_frame_validation.patch has to be updated to meet the latest
vp8_cx_iface.c

Depends on D204802

Assignee

Comment 13

•

8 months ago

Attached file Bug 1880814 - Apply local patches — Details

This patch runs

./mach vendor media/libvpx/moz.yaml --patch-mode=only

to apply local patches.

Depends on D204803

Updated

•

8 months ago

Attachment #9391517 - Attachment description: WIP: Bug 1880814 - Update to 7fb8ceccf92c35cd5131b05c0502916715ebc76b → WIP: Bug 1880814 - Update libvpx to 7fb8ceccf92c35cd5131b05c0502916715ebc76b

Updated

•

8 months ago

Attachment #9391518 - Attachment description: WIP: Bug 1880814 - Update input_frame_validation.patch → WIP: Bug 1880814 - Adjust input_frame_validation.patch