1886378 - arm_neon_sve_bridge.h: No such file or directory when compiling libvpx

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Dan Horák]

I am getting a build failure on Linux/aarch64 (Fedora 38) in recent trunk, see bellow

...
/usr/bin/gcc -std=gnu99 -o vp9_error_sve.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DHAVE_CONFIG_H=vpx_config.h -DMOZ_HAS_MOZGLUE -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/obj-aarch64-unknown-linux-gnu/media/libvpx -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx/config/linux/arm64 -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx/config -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx/libvpx -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/obj-aarch64-unknown-linux-gnu/dist/include -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/obj-aarch64-unknown-linux-gnu/dist/include/nspr -I/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/obj-aarch64-unknown-linux-gnu/dist/include/nss -include /home/jenkins/workspace/Firefox-default/label/aarch64/firefox/obj-aarch64-unknown-linux-gnu/mozilla-config.h -DMOZILLA_CLIENT -g0 -fPIC -fno-math-errno -pthread -gdwarf-4 -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wduplicated-cond -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-psabi -Wno-error=builtin-macro-redefined -Wno-sign-compare -Wno-unused-function -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/vp9_error_sve.o.pp  -march=armv8.2-a+dotprod+i8mm+sve /home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx/libvpx/vp9/encoder/arm/neon/vp9_error_sve.c
In file included from /home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx/libvpx/vp9/encoder/arm/neon/vp9_error_sve.c:17:
/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/media/libvpx/libvpx/vpx_dsp/arm/vpx_neon_sve_bridge.h:16:10: fatal error: arm_neon_sve_bridge.h: No such file or directory
   16 | #include <arm_neon_sve_bridge.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[4]: *** [/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/config/rules.mk:600: vp9_error_sve.o] Error 1
gmake[4]: Leaving directory '/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/obj-aarch64-unknown-linux-gnu/media/libvpx'
gmake[3]: *** [/home/jenkins/workspace/Firefox-default/label/aarch64/firefox/config/recurse.mk:72: media/libvpx/target-objects] Error 2

Something changed in the last ~10 days, unfortunately I haven't seen this earlier.

Comment 1

[Dan Horák]

I believe it is related to bug #1880814

Comment 2

[Dan Horák]

bisecting points to https://github.com/mozilla/gecko-dev/commit/9ed06e0f8fb68625b399e6b6701b4a5827f2eea1

Comment 3

[C.M.Chang[:chunmin]]

Ah, I think the SVE feature needs to be disabled on linux/aarch64 as we do in Windows/AArch64: https://phabricator.services.mozilla.com/D204798. Keep the NI until I submit the patch.

Comment 4

[Dan Horák]

The missing header file seems to be provided by the compiler and will be available when building with GCC 14+, if I see right.

Comment 5

[C.M.Chang[:chunmin]]

(In reply to Dan Horák from comment #4)

The missing header file seems to be provided by the compiler and will be available when building with GCC 14+, if I see right.

Hey Dan, good to hear the news! Let me know if the build works with GCC 14+.

Comment 6

[Dan Horák]

I don't have a system with gcc 14 handy right now, but it's my plan to check that. Anyway, gcc 14 hasn't been released yet, so at least a check about the SVE support would be useful in the buildsystem. Haven't checked how it looks with clang.

Comment 7

[Donal Meehan [:dmeehan]]

:chunmin the Fx126 soft code freeze starts next week.
Do you plan on patching this before Fx126 goes to beta on 2024-04-15

Comment 8

[C.M.Chang[:chunmin]]

Yes, I'll submit a patch oncebug 1888772 is resolved.

Comment 9

[C.M.Chang[:chunmin]]

I am testing on CI for SVE-disabled linux/aarch64: https://treeherder.mozilla.org/jobs?repo=try&revision=14a7bd0163b6df26c646b5d5387dcc5b812fd21d&selectedTaskRun=MRCmpKDAS8yeP6JD1BFYNg.0

Comment 10

[C.M.Chang[:chunmin]]

Attachment: Bug 1886378 - Disable SVE on linux/aarch64

This patch, akin to D204798 in bug 1880814 [1, 2], disables the SVE
features on the Linux/AArch64 platform.

[1] https://phabricator.services.mozilla.com/D204798
[2] https://hg.mozilla.org/mozilla-central/rev/d3a921beb422

Comment 11

[C.M.Chang[:chunmin]]

Attachment: Bug 1886378 - Rework source-list generation across platforms and architectrues

This patch, similar to D204801 in bug 1880814 [1, 2], removes the
SVE-related files ending with _sve.c from the libvpx sources on Linux
AArch64 platforms. The SVE feature was disabled in the preceding patch.

[1] https://phabricator.services.mozilla.com/D204801
[2] https://hg.mozilla.org/mozilla-central/rev/a708b3c2ddc0

Depends on D206718

Comment 12

[C.M.Chang[:chunmin]]

Attachment: Bug 1886378 - Update linux/aarch64 sources to SVE-disabled version

This patch updates the linux/aarch64 sources in our code base to the
SVE-disabled version. The commit version remains at 7fb8cec.

Depends on D206719

Comment 13

[Dan Horák]

with the 3 changes applied I can build Firefox again on Fedora 38 on aarch64 (with gcc-13.2.1-7.fc38.aarch64)

Comment 14

[Dan Horák]

And I have got my hands on Fedora Rawhide system with gcc 14 so I retried the build there and it still fails. A closer look shows that the arm_neon_sve_bridge.h got added only in December 2023 into the gcc git tree, which will make it available first in gcc 15 I believe.

Comment 15

[C.M.Chang[:chunmin]]

Attachment: Bug 1886378 - Include vpx_config.c directly in source list

Initially, vpx_config.c on various platform-architecture combinations
was revmoed from the input list for source list generation and later
added to the source list in moz.build. This was necessary because the
generated list was based solely on architecture, while the vpx_config.c
differed across platform-architecture combinations.

With the source list generation reworked in the previous patch, each
platform-architecture combination now has its own list. Therefore,
vpx_config.c can be directly included in the source list, simplifying
the process.

Depends on D206719

Comment 16

[C.M.Chang[:chunmin]]

Attachment: Bug 1886378 - Update linux/aarch64 sources to SVE-disabled version

This patch updates the linux/aarch64 sources in our code base to the
SVE-disabled version. The commit version remains at 7fb8cec.

Depends on D207183

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2143ac890f26
Disable SVE on linux/aarch64 r=glandium
https://hg.mozilla.org/integration/autoland/rev/bdcc287fced5
Rework source-list generation across platforms and architectrues r=glandium
https://hg.mozilla.org/integration/autoland/rev/e82d37e48dcd
Include vpx_config.c directly in source list r=glandium
https://hg.mozilla.org/integration/autoland/rev/bfaf7b3f0e79
Update linux/aarch64 sources to SVE-disabled version r=glandium

Comment 18

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2143ac890f26
https://hg.mozilla.org/mozilla-central/rev/bdcc287fced5
https://hg.mozilla.org/mozilla-central/rev/e82d37e48dcd
https://hg.mozilla.org/mozilla-central/rev/bfaf7b3f0e79

Comment 19

[Dan Horák]

Confirming it builds OK again on aarch64 after the committed changes.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:chunmin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 21

[C.M.Chang[:chunmin]]

This bug just disables SVE features on Linux, so there should be no impactful functionality changes, and has no need to be uplifted.