1880835 - Bottom of gpqj letters (descenders) is cut off in the emails list when compact density is used

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P1)

Description

[Strangiato]

Attachment: fontstb.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Steps to reproduce:

1. click on the hamburger menu
2. choose "Compact" density

Actual results:

As we can observe in the attached screenshot, bottom of gpqj letters is cut off in the emails list.

Expected results:

All letters should be entirely readable.

Comment 1

[Strangiato]

I'm using thunderbird 115.7.0-2 on Arch Linux.

Comment 2

[Anje]

What Font Size are you using ?
Menu app icon (hamburger) > Font Size
What does it say you are using for the ?px ?

I find up to and including Font Size 15px works ok with 'Compact' density.
But Font Size 16px starts to lose the lower section of same letters if I still use 'Compact'.
If I want to use 16px or more then I need to offer more space for those letters that use more space, swapping to use 'Default' for Font Size 16px or more works ok, but it's a workaround and compact should still work no matter what font size is selected. So I agree this is a bug.

Comment 3

[Anje]

Testing using beta 123.0b5
Using density: 'Compact'

I find the issue only occurs in the Message List / Thread Pane.
This only occurs in 'Table View'.
As the Font Size is increased to 16px or more, the row height does not adjust correctly.

In 'Card View', there is a slight overlap but only with Font Size 15px, less than or more than 15px seems ok.

I find the 'Folder Pane' manages the row height to cope with the increase in Font Size.

Comment 4

[Strangiato]

I have updated to version 115.8 and the bug persists. Font size is 18px.

Comment 5

[solange]

Attachment: Bug 1880835 - Update table row height/density to be font size dependant. r=aleca,freaktechnik,#thunderbird-front-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/69f2d66fd3a6
Update table row height/density to be font size dependant. r=aleca,freaktechnik

Comment 7

[Magnus Melin [:mkmelin]]

This seems to be causing a perma failing comm/mail/base/test/widgets/browser_treeView.js | the table body should be 630px tall - 630.2000122070312 == 630 - got 630.2000122070312

Comment 8

[Magnus Melin [:mkmelin]]

It's because of calculations, like https://hg.mozilla.org/comm-central/rev/69f2d66fd3a6#l3.11
It doesn't seem great that we end up with sub-pixles for that, so I'm not sure what the solution is.
Probably best to back out until to give time to explore that.

Comment 9

[Brendan Abolivier [:babolivier]]

Patch fails to apply to comm-central:

Patching revision: D203215
Checked out .
patching file mail/themes/shared/mail/tree-listbox.css
Hunk #1 FAILED at 1
Hunk #2 FAILED at 25
2 out of 2 hunks FAILED -- saving rejects to file mail/themes/shared/mail/tree-listbox.css.rej
patching file mail/themes/shared/mail/threadPane.css
Hunk #1 FAILED at 376
1 out of 1 hunks FAILED -- saving rejects to file mail/themes/shared/mail/threadPane.css.rej
patching file mail/base/content/about3Pane.js
Hunk #1 FAILED at 4586
1 out of 1 hunks FAILED -- saving rejects to file mail/base/content/about3Pane.js.rej
abort: patch failed to apply

This likely needs rebasing before it can land.

Comment 10

[Brendan Abolivier [:babolivier]]

Ah, just realised the checkin-needed-tb keyword was for a backout, ignore me.

Comment 11

[Brendan Abolivier [:babolivier]]

Backed out from comm-central for causing test failures: https://hg.mozilla.org/comm-central/rev/7bae9d0a5a1bb1dcbe52cc1336706871b35fc819

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8b4a37d1b80
Update table row height/density to be font size dependant. r=aleca,freaktechnik