Closed Bug 1880862 Opened 9 months ago Closed 9 months ago

The location-sign is duplicated when a Yelp suggestion is triggered using the “in” location-sign

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
125 Branch
Tracking Status
firefox124 --- verified
firefox125 --- verified

People

(Reporter: cfat, Assigned: daisuke)

References

Details

(Whiteboard: [sng])

Attachments

(2 files)

[Affected versions]:

  • Firefox Nightly 125.0a1 - Build ID: 20240219095613

[Affected Platforms]:

  • Windows 10 x64
  • macOS 12.6.1
  • Linux Ubuntu 20.04 x64

[Prerequisites]:

  • Have the following prefs set with the values to enable the feature:
    browser.search.region = US (connect to a VPN server if outside US)
    browser.urlbar.quicksuggest.rustEnabled = true
    browser.urlbar.suggest.yelp = true
    browser.urlbar.yelp.featureGate = true
    browser.urlbar.yelp.priority = true

[Steps to reproduce]:

  1. Open the browser with the profile from the prerequisites.
  2. Type the “burgers in” string in the Address Bar.
  3. Observe the wording of the Yelp result.

[Expected result]:

  • “burgers in (city, state)” suggestion is displayed.

[Actual result]:

  • “burgers in in (city, state)” suggestion is displayed.

[Notes]:

  • This issue affects Yelp results displayed on both Top Pick and Firefox Suggest locations.
  • Attached is a screenshot of the issue.
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Depends on: 1881156
Priority: -- → P1
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ffb47db9cac Avoid duplicate location-sign written in title r=adw
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch

STR for QA

  1. Enable Suggest and Yelp suggestions: browser.urlbar.yelp.featureGate = true
  2. Type a Yelp query that ends in a location sign ("in" or "near"), e.g. "ramen in"
  3. In the suggestion title, verify your geolocation city appears directly after the location sign you typed. No extra "in" or anything else should be added to the title except the city (and possibly US state). e.g. "ramen in Chicago", "ramen in Chicago, Illinois", "ramen near Chicago". Not "ramen in in Chicago" or "ramen near in Chicago"
  4. Type another Yelp query that ends in a location modifier ("near me", "nearby", "near by", "in area"), e.g. "ramen near me", "ramen nearby"
  5. In the suggestion title, verify "in <your geolocation city>" appears directly after the location modifier you typed. Note this is the opposite from step 3. Here, "in" should be added as part of the title. e.g. "ramen near me in Chicago", "ramen nearby in Chicago"
Flags: qe-verify+
Flags: in-testsuite+

Comment on attachment 9381134 [details]
Bug 1880862: Avoid duplicate location-sign written in title

Beta/Release Uplift Approval Request

  • User impact if declined: This is necessary for the Yelp suggestions experiment that will target 124.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Please see previous comment and comment 0
  • List of other uplifts needed: The following Yelp bugs need uplift in this order: bug 1881071, bug 1881606, bug 1880667, bug 1882174, bug 1880862 (this bug)
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This only affects Yelp suggestions, which are disabled by default, and it's only a cosmetic change to the suggestion title. Has automated tests.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9381134 - Flags: approval-mozilla-beta?
Whiteboard: [sng]

Comment on attachment 9381134 [details]
Bug 1880862: Avoid duplicate location-sign written in title

Approved for 124.0b6

Attachment #9381134 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240229093832) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

  • Only the city is added in the Yelp suggestion after typing a location sign (“in”, “near”).
  • “in <city>” is added in the Yelp suggestion after typing a location modifier (“near me”, “nearby”, “near by”, “in area”.
  • There are no duplicated strings in the suggestion for both of the scenarios above.

I have verified this issue on Firefox Beta 124.0b6 (Build ID: 20240301091852) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

  • Only the city is added in the Yelp suggestion after typing a location sign (“in”, “near”).
  • “in <city>” is added in the Yelp suggestion after typing a location modifier (“near me”, “nearby”, “near by”, “in area”.
  • There are no duplicated strings in the suggestion for both of the scenarios above.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: