Closed
Bug 1882174
Opened 1 years ago
Closed 1 years ago
Do another final vendor + uplift of a-s into m-c for Suggest Yelp suggestions
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
125 Branch
People
(Reporter: adw, Assigned: daisuke)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
We need to do another vendor of a-s into m-c and then uplift it to 124 to pick up Yelp changes to the Suggest component.
Updated•1 years ago
|
Assignee | ||
Updated•1 years ago
|
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•1 years ago
|
||
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eaf64fb1229a
Vendor application-services into mozilla-central r=adw,lina
Comment 3•1 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Reporter | ||
Updated•1 years ago
|
status-firefox124:
--- → affected
Reporter | ||
Comment 4•1 years ago
|
||
The phabricator attachment doesn't have the usual option to request uplift, maybe because this bug is in Application Services? I'll see if moving it to Address Bar makes it show up.
Component: General → Address Bar
Product: Application Services → Firefox
Reporter | ||
Updated•1 years ago
|
Flags: qe-verify-
Flags: in-testsuite+
Reporter | ||
Comment 5•1 years ago
|
||
Comment on attachment 9387966 [details]
Bug 1882174: Vendor application-services into mozilla-central
Beta/Release Uplift Approval Request
- User impact if declined: This is necessary for the Yelp suggestions experiment that will target 124.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: The following Yelp bugs need uplift in this order: bug 1881071, bug 1881606, bug 1880667, bug 1882174 (this bug), bug 1880862
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a vendor of application-services Rust code into m-c. It only contains changes to the implementation of Yelp suggestions, which are disabled by default. All this code has test coverage.
- String changes made/needed:
- Is Android affected?: No
Attachment #9387966 -
Flags: approval-mozilla-beta?
Comment 6•1 years ago
|
||
Comment on attachment 9387966 [details]
Bug 1882174: Vendor application-services into mozilla-central
Approved for 124.0b6
Attachment #9387966 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•1 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•