1880667 - The Firefox icon and text of the message displayed after dismissing a Yelp suggestion are misaligned

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: text ty message.jpg

[Affected versions]:

• Firefox Nightly 124.0a1 - Build ID: 20240216094648

[Affected Platforms]:

• Windows 10 x64
• macOS 12.6.1
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have the following prefs set with the values to enable the feature:
  browser.search.region = US (connect to a VPN server if outside US)
  browser.urlbar.quicksuggest.rustEnabled = true
  browser.urlbar.suggest.yelp = true
  browser.urlbar.yelp.featureGate = true
  browser.urlbar.yelp.priority = true

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Type the “sushi” string in the Address Bar.
3. Click the “Feedback” button.
4. Click the “Don’t show this” option.
5. Dismiss the suggestion by clicking any of the “Not relevant” or “Not interested” options.
6. Observe how the message is displayed.

[Expected result]:

• The Firefox icon and “Thanks for your feedback” text are horizontally aligned in the middle of the message row.

[Actual result]:

• The Firefox icon and “Thanks for your feedback” text are placed higher, in the top half area of the message row.

[Notes]:

• This issue affects Yelp results displayed on both Top Pick and Firefox Suggest locations.
• Attached is a screenshot of the issue.

Comment 1

[Drew Willcoxon :adw]

This was regressed by bug 1851481.

Comment 2

[Drew Willcoxon :adw]

All tips are broken, not only the dismissal acknowledgment, but most other tips have larger block padding, which makes it not look quite as bad.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1880667 - Vertically center-align urlbar tips.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1851481

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc25e9531ce3
Vertically center-align urlbar tips. r=dao,desktop-theme-reviewers

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bc25e9531ce3

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240228100509) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

• The Firefox icon and “Thanks for your feedback” text are horizontally aligned in the middle of the message row.

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 9382765 [details]
Bug 1880667 - Vertically center-align urlbar tips.

Beta/Release Uplift Approval Request

• User impact if declined: This is necessary for the Yelp suggestions experiment that will target 124.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See previous comments
• List of other uplifts needed: The following Yelp bugs need uplift in this order: bug 1881071, bug 1881606, bug 1880667 (this bug), bug 1882174, bug 1880862
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small CSS-only styling change that vertically centers some items in the urlbar panel.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9382765 [details]
Bug 1880667 - Vertically center-align urlbar tips.

Approved for 124.0b6

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/df51be830a33

Comment 12

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on Firefox Beta 124.0b6 (Build ID: 20240301091852) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

• The Firefox icon and “Thanks for your feedback” text are horizontally aligned in the middle of the message row.