1881001 - Use the same AGP version for AC and GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, task, P2)

Comment 1

[Julien Cristau [:jcristau]]

With 8.1.0 or 8.2.2, https://searchfox.org/mozilla-central/rev/97feebcab27f1a92e70ceacaa77211e9eaba0e6e/mobile/android/geckoview/build.gradle#531 ends up with an empty bootClasspath, which breaks the generateSDKBindings task.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Now that we've done the repo migration, we should aim to use ComponentsDependencies.tools_androidgradle in build.gradle and ComponentsDependencies.tools_lint & ComponentsDependencies.tools_lintchecks in mobile/android/annotations/build.gradle from the AC dependencies plugin rather than manually setting versions once the build issues can be identified and fixed.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

We may also need to carry over setting android.enableNewResourceShrinker.preciseShrinking to false in the GV gradle.properties like we're doing for the AGP 8.3.0 update for AC et al.

Comment 4

[Mihai Adrian Carare [:mcarare]]

Looks like this is also blocking building GVE with compile SDK 35.
Not sure if Google will fix it ( maybe it is infeasible) or just recommend updating AGP: https://issuetracker.google.com/issues/343592384

Comment 5

[Nicolas Guichard]

When trying to add AC/Fenix/Focus/Klar to mach android compile-all I got hit by this:

Could not determine the dependencies of task ':browser-domains:compileReleaseJavaWithJavac'.
> Could not determine the dependencies of null.
   > Failed to find Build Tools revision 30.0.3

I tracked this down to AGP 8.0.2 defaulting to Build Tools 30.0.3 but that version was removed from the android-sdk-linux toolchain. GeckoView has an explicit buildToolsVersion set but not the other projects. It looks like they all ended up using the same AGP 8.0.2 but only GeckoView used Build Tools 34.0.0.

I have a fix for this that I'll send for review shortly.

Comment 6

[Nicolas Guichard]

Attachment: Bug 1881001 - Use the same AGP version for AC and GeckoView. r=nalexander!

Delaying the definition of the generateSDKBindings task ensures the
android.bootClasspath has been populated.

Updating AGP apparently changes the location of apilint-result.json.

Comment 7

[Mihai Adrian Carare [:mcarare]]

Regarding comment 4, I tested the attached patch added to my patch and it solves the issue I reported.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb385d942e86
Use the same AGP version for AC and GeckoView. r=geckoview-reviewers,nalexander,owlish

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bb385d942e86