1909623 - Building Fenix (not Focus) from gradle root fails because of unknown project :mozilla-lint-rules

Status: RESOLVED FIXED

(Fenix :: Tooling, defect)

Description

[Titouan Thibaud [:titouan]]

Steps to reproduce

Checkout the last central/default
Run mach build
Open the root folder on Android Studio
Sync with Gradle

Expected result

Gradle sync finishes successfully

Actual result:

A build operation failed.
    Could not resolve all files for configuration ':fenix:lintPublish'.
Could not resolve all files for configuration ':fenix:lintPublish'.
Could not resolve project :mozilla-lint-rules.
Required by:
    project :fenix
A dependency was declared on configuration 'default' which is not declared in the descriptor for project :mozilla-lint-rules.

Comment 1

[Titouan Thibaud [:titouan]]

For a reason that we don't understand, the patch that fixed this similar issue 2 months ago (Bug 1891130) needs to be reverted to fix the build.

Comment 2

[Titouan Thibaud [:titouan]]

Attachment: Bug 1909623 - Fix building Fenix from mozilla-central root folder.

Fixing the error: Could not resolve project :mozilla-lint-rules.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:tthibaud, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit BugBot documentation.

Comment 4

[Titouan Thibaud [:titouan]]

I think it's not exactly a regression, as the patch for Bug 1891130 was fixing the issue at that time, and something recently change (we're not sure what) that now requires to change back to use lintChecks in the Fenix app build.gradle

Comment 5

[Kaya [:kaya]]

Linked the regression.

These version updates caused the regression:
https://searchfox.org/mozilla-central/rev/79f37e7fcd8994d86b0c610a87af4ef0343166ee/mobile/android/annotations/build.gradle#6-7
https://searchfox.org/mozilla-central/rev/79f37e7fcd8994d86b0c610a87af4ef0343166ee/build.gradle#28

I tried using AGP v8.3.2 and lint v31.3.2 versions and they are working with the current production code. Probably somethings have changed in v8.4.0 (our current version), that might have impacted the behavior of lintPublish and lintChecks configurations. I could not spot any reference in the release notes.
Worth noting, I've tested this on Android Studio Jellyfish | 2023.3.1 Patch 2 which got a patch release for AGP v8.4.2. Upgrading to AGP v8.4.2 (and lint v31.4.2) did not help.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881001

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8d93e10293e
Fix building Fenix from mozilla-central root folder. r=android-reviewers,mcarare

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e8d93e10293e