1881124 - Creating a tag with a number as name in general settings throws an error.

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[klaus]

Use UI to create a tag with name 2. If this name is not allowed, there should be an error message.

Uncaught DOMException: Element.querySelector: 'richlistitem[value=2]' is not a valid selector
addTagCallback chrome://messenger/content/preferences/general.js:2929
onOKNewTag chrome://messenger/content/newTagDialog.js:90
_fireButtonEvent chrome://global/content/elements/dialog.js:515
_doButtonCommand chrome://global/content/elements/dialog.js:494
_handleButtonCommand chrome://global/content/elements/dialog.js:488
2 general.js:2929
addTagCallback chrome://messenger/content/preferences/general.js:2929
onOKNewTag chrome://messenger/content/newTagDialog.js:90
_fireButtonEvent chrome://global/content/elements/dialog.js:515
_doButtonCommand chrome://global/content/elements/dialog.js:494
_handleButtonCommand chrome://global/content/elements/dialog.js:488

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1881124 - Fix selecting newly created tag in general settings. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1bf93b9619e0
Fix selecting newly created tag in general settings. r=mkmelin

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9382017 [details]
Bug 1881124 - Fix selecting newly created tag in general settings. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1852414
User impact if declined: tags with a number as name appear to be not valid
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): none

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9382017 [details]
Bug 1881124 - Fix selecting newly created tag in general settings. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.10.0:
https://hg.mozilla.org/releases/comm-esr115/rev/3f6c1f66acaa

Comment 6

[Rob Lemley [:rjl]]

Backout:
https://hg.mozilla.org/releases/comm-esr115/rev/ce3afbba114d

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.10.0:
https://hg.mozilla.org/releases/comm-esr115/rev/3d316365b67a