1852414 - Tag dialog window does not close after edit tag

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[TTg]

Steps to reproduce:

Go into preferences - Tags - Edit a tag (word) - select a color and confirm by clicking Ok button - select Ok button again

Actual results:

The color setting is applied but the dialog box 'edit tag' does not close

Expected results:

The color setting is applied and the dialog box closes

Comment 1

[Magnus Melin [:mkmelin]]

Since https://hg.mozilla.org/comm-central/rev/284edc215746#l2.51 now keep tags up to date, https://searchfox.org/comm-central/rev/ba6f649324db7853c67baaa98e12b81561394419/mail/components/preferences/general.js#2937 will not find have a selection and then prevent closing.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1852414 - Make tag dialog window close properly after edit tag. r=darktrojan

As we now observe and adjust the list automatically, the things this code tried to do is no longer wanted.
Move more updating to take place automatically.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3ba8f380365
Make tag dialog window close properly after edit tag. r=darktrojan

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9352474 [details]
Bug 1852414 - Make tag dialog window close properly after edit tag. r=darktrojan

[Triage Comment]
Approved for beta to fix regression

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/135d4b95e864

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9352474 [details]
Bug 1852414 - Make tag dialog window close properly after edit tag. r=darktrojan

[Triage Comment]
Approved for esr115 (and has tests)

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/657e6b7b57c2