1883337 - Firefox View websites in window cannot be browsed anymore after following specific steps

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: media indicator.webm

Found in

• Firefox 124.0b6

Affected versions

• Firefox 124.0b6
• Firefox 125.0a1

Tested platforms

• Affected platforms: Ubuntu 22.04, macOS 13.6.4, Windows 10

Precondition

• Have multiple windows with ongoing media from Youtube

Steps to reproduce

1. Restart Firefox after setting up the precondition
2. Access Open Tabs in Firefox View
3. Tab through the websites in the Window list
4. Select a media indicator and press space/enter

Expected result

• The media icon mutes/unmutes (depends on the case)

Actual result

• The media icon disappears, focus is lost and the websites on that respective window cannot be browsed anymore by keyboard

Additional notes

• The issue can be seen in the attachment
• Autoplay is blocking the websites from starting after a restart, so maybe there shouldn't be any media indicator in these cases? (some Youtube sessions will retain the indicator and some don't, as seen in the attachment too).

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c23d6a5f066e
Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman

Comment 3

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9389155 [details]
Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View

Beta/Release Uplift Approval Request

• User impact if declined: Focus will be lost on Open Tabs in Fx View if they mute/unmute a tab using the keyboard
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Mute a tab that does NOT have sound playing. It can be anything really as long as sound is not playing.
• Unmute the tab using the keyboard by tabbing to the list, then using arrow keys to select the Unmute button and hit Enter or Space
• Once the mute/unmute button is removed from the row, ensure that focus has been moved to the right (secondary/more button) unless using RTL
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Modifies one method in fxview-tab-list.mjs and adds a test to prevent this issue from reoccurring
• String changes made/needed: N/A
• Is Android affected?: No

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_opentabs_pinned_tabs.js

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adf17fc47c84
Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/adf17fc47c84

Comment 7

[Dianna Smith [:diannaS]]

:kochrane this doesn't graft cleanly to beta because some of these tests (browser_tab_list_keyboard_navigation.js, browser_opentabs_pinned_tabs.js) don't exist in beta yet. They seem to have been added by bug 1857298 and bug 1849175 for fx125.
When was this regressed? given that it is an S4, this might be better to ride the trains with 125... thoughts?

Comment 8

[Catalin Sasca, Desktop Test Engineering [:csasca]]

We were about to verify the fix for this but it seems that a regression was introduced in 125.0a1 (2024-03-06) on all platforms, in which only by tabbing through an ongoing media website in Open tabs will automatically mute/unmute the tab. see attachment

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9389155 [details]
Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View

This looks like it might not be affecting 124 based on QA comment

Comment 10

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9389155 [details]
Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View

Yeah let's go ahead and cancel the uplift request for 124 please. Confirmed with :sclements.

:csasca, Could we write up this new issue/regression as a new bug when you get the chance, since this one has already had stuff land to central, and this bug was resolved as fixed? We can mark it as a regression of this bug. Thanks!

Comment 11

[Dianna Smith [:diannaS]]

its cancelled. ill leave the NI for :csasca to follow up on the regression

Comment 12

[Kelly Cochrane [:kcochrane]]

I believe 124 is still affected by this original bug, but since severity was set to S4, we agreed we can just let it ride the trains with 125.

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Logged Bug 1884322 for the regression. Thanks!

Comment 14

[Catalin Sasca, Desktop Test Engineering [:csasca]]

We looked over verifying the fix for the initial issue but it seems it does still reproduce on latest Nightly (see attachment). Window 2 will still let me browse between the websites, but Window 1 will not, as soon as the media icon disappears.

Comment 15

[Kelly Cochrane [:kcochrane]]

Attachment: Screen Recording 2024-03-08 at 8.54.03 AM.mov

Hi, :csasca, I'm not able to reproduce with Nightly version 125.0a1 (2024-03-08). Was it possible you weren't updated to the latest version?

Comment 16

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Yep, just tried on Firefox 125.0a1 (2024-03-10) after Bug 1884322 was fixed and it seems that the issue is no longer reproducing. Tests were performed on macOS 13.6.5, Windows 11 and Ubuntu 23.10. Thanks Kelly!