1849175 - Pinned tabs don't show on "open tabs" section

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Brent]

As a user, I'd like to see the tabs I have pinned on the Open Tabs view.

fidefe-firefox-view

Comment 1

[Haik Aftandilian [:haik]]

This seems more like a bug than an enhancement. My expectation is that a tab list would include pinned tabs like the tab overflow menu. Seeing the pinned tabs in the open tab lists also helps to make it clear which window is which. In terms of consistency, pinned tabs are included in "Tabs from other devices" list and when closed in the "Recently closed tabs" list.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Agreed, pinned tabs should be included in the list, should probably be always sorted to the top? And should have some visual indication that they are pinned.

Comment 3

[Eric Pang [:epang] UX]

Added a UX spec for Pinned tabs in Open tabs here on figma.
https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=6713%3A490572&mode=design&t=n4n7LSdb7XFjDfNV-1

Note: this section of the spec also includes indicators, which are not part of this bug and will follow in the future based on product priority.

Comment 5

[Sam Foster [:sfoster] (he/him)]

I'm not currently working on this.

Comment 7

[Kelly Cochrane [:kcochrane]]

Decision from UX according to [:epang]: We should only show pinned tabs as the grid view on the Open Tabs page. On the Recent Browsing page, pinned tabs should show in list form if they are one of the top 5 most recently opened tabs.

For a couple of reasons:

1. Wanted to respect that the recent browsing was recent
2. Users have access to the pinned tabs in their tab strip
3. It would be difficult to decide which pinned tabs to show if there are different pins across different windows

but if we start seeing the need (if bugs start coming in), we'll have to do more thinking.

Comment 8

[Kelly Cochrane [:kcochrane]]

After discussion with a11y team, we've decided to implement this as one fxview-tab-list component containing two sublists:

• One with role="tablist" and name="Pinned Tabs" containing buttons with role="tab"
• The other containing unpinned tabs as rows with links and the 3-dot menu button as they exist today

Users will be able to tab to the first unpinned tab in the list and then use arrow left/right to get through the list or arrow down to the unpinned tabs list.

Comment 10

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9c17890d242
Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao

Comment 13

[Cristian Tuns]

Backed out for causing bc failures in browser_opentabs_firefoxview.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_opentabs_firefoxview.js | Test timed out -

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67fd66802500
Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao

Comment 15

[Natalia Csoregi [:nataliaCs]]

Backed out for conflicting with the backout of Bug 1877678:

• backout: https://hg.mozilla.org/integration/autoland/rev/c07cc5fbfa5a082e4acf66d95dbf935cccb7fe41

Sorry if this has caused any inconvenience, will try to reland after the backout reaches the tree.

LE: this can't be relanded due to more conflicts

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c34ad04103d
Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c34ad04103d

Comment 19

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed Fx 125.0a1 and Fx 125.0b3 Win 10x64, Ubuntu 22 and macOS 14.