1883872 - CSS: Intrinsic sizing of table elements crops elements

Status: NEW

(Core :: Layout: Tables, defect, P3)

Description

[Jonathan Kingston [:jkt] he/him]

Attachment: sizing-demo.html

When elements in a table are positioned relatively with no sizing the elements appear to be cropped.
This doesn't happen in Firefox stable or beta and only Nightly 125.0a1 (2024-02-26) (64-bit) MacOS.

See attached PoC that also works fine in Safari.

This was first noticed on https://veloviewer.com when logged in and viewing elements in the table.

Comment 1

[Jonathan Kingston [:jkt] he/him]

First bad mozilla central build was: 2024-01-23

2024-03-06T11:28:44.181000: INFO : Narrowed integration regression window from [0426af8e, 2211ddf3] (3 builds) to [5c38b3e5, 2211ddf3] (2 builds) (~1 steps left)
2024-03-06T11:28:45.621000: DEBUG : Found commit message:
Bug 221154 - Tweak a few crashtest assertion counts. r=dholbert

Bisect is pointing at: https://phabricator.services.mozilla.com/D199241

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 221154

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Thanks for filing! Yeah this happens to be more fallout that depends on bug 1883699 for a correct fix. It's similar to the vertical-align stuff that I'm looking at in bug 1877719.

The TLDR is that I need to make the scrollbox stretch, and for that I kinda need to dig into this whole rabbit-hole of rewriting a bunch of our ancient table code. For now this is disabled outside of Nightly.

I plan to look at that relatively soon. Otherwise we should disable the scrollable table cells on nightly too.

Just to confirm, the breakage on the website doesn't happen if you switch layout.tables.scrollable-cells to false right?

Comment 4

[Jonathan Kingston [:jkt] he/him]

Yup works fine once that pref is disabled :)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 221154