1884131 - Redirected to a broken login page when searching on taobao.com

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Calin Tanase]

Attachment: taobao FF vs Chrome.mp4

Environment:
Operating system: OnePlus 6 A6000 (Android 11)
Firefox version: Nightly 125.0a1-20240306095835

Steps to reproduce:

1. Go to https://main.m.taobao.com
2. Tap on the search bar.
3. Tap again on the search bar when redirected.
4. Search for anything.
5. Observe the login page.

Expected Behaviour:
The buttons are displayed on the login page.

Actual Behaviour:
The buttons are missing from the login page.

Notes:

1. Screen rec attached
2. Reproducible on Firefox Release as well
3. Reproducible regardless of the ETP status
4. Not reproducible on Chrome
5. Workaround: refreshing the page displays it correctly
6. The search page is also broken until the login page is refreshed (home icon missing from the header)
7. Issue found during WebCompat team [Top100] websites testing

Comment 1

[Daniel Holbert [:dholbert]]

So these elements are there, but they're inside a 100%-height-iframe which lives inside of this element in the top-level page:

<div style="
  transform: scale(1) translateZ(0px);
  transform-origin: 0px 0px 0px;
  width: 414px; height: 468px;
  z-index: 2147483647;
  position: fixed; left: 0px; top: 0px;
  background: rgb(255, 255, 255);
  display: block;"
  class="J_MIDDLEWARE_FRAME_WIDGET">

This element has a limited height (note height: 468px;) which the iframe takes on via its 100% height; and that isn't tall enough to show all of the content, so the buttons overflow off the bottom of the iframe and don't end up being visible.

Comment 2

[Daniel Holbert [:dholbert]]

If I reload the login page after hiding the keyboard, then it renders just fine, and this J_MIDDLEWARE_FRAME_WIDGET element has height:788px instead.

I think the issue is that the page is sizing this J_MIDDLEWARE_FRAME_WIDGET element to fit the available screen space, measured via some sort of JS query of the page layout. And at-the-moment-of-pageload, the on-screen-keyboard is taking up half the screen, so the J_MIDDLEWARE_FRAME_WIDGET element ends up using a size that's much smaller than the actual screen.

Comment 3

[Daniel Holbert [:dholbert]]

I haven't debugged their JS to see how they come up with their magic specified-height for this J_MIDDLEWARE_FRAME_WIDGET element (whether 788px or 468px), but given that this is about the keyboard stealing screen real-estate from an element that's meant to be ~full-screen, I'd bet this is a version of bug 1007286. (See e.g. testcases on my dupe bug 1826410.)

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Daniel is right. I tried the site on my local built Fenix with the patch series for bug 1831649 and an additional change to make resizes-visual as the default interactive-widget value, it works fine.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Calin, can you try reproducing on Nightly?

Comment 6

[Calin Tanase]

No longer reproduces on the latest Nightly.

Environment:
Operating system: OnePlus 6 A6000 (Android 11)
Firefox version: Nightly 132.0a1-20240904095513

Comment 7

[Botond Ballo [:botond]]

Reopening as discussed in bug 1842574 comment 11, to reflect that the release version is still affected until bug 1916002 is fixed.

Comment 8

[Raul Bucata]

Verified the issue and could no longer reproduce it. The buttons are present on the login page and nothing seems broken on Release. However, on Nightly I am redirected once the login page briefly loads, to a "Sorry, Firefox Nightly can't load that page" error page ( the login page shows all the elements before being redirected).

Tested with:

Browser / Version: Firefox Release 132.0.2 (2016055415-🦎132.0.2-20241110192737🦎)/Firefox Nightly 134.0a1 (2016056767-🦎134.0a1-20241117211558🦎)/
Operating System: Google Pixel 3 (Android 12) -1080 x 2160 pixels, 18:9 ratio (~443 ppi density)
Operating System: Oppo Find X5 (Android 13) - 1080 x 2400 pixels, 20:9 ratio (~402 ppi density)

Comment 9

[Botond Ballo [:botond]]

Thanks for testing!

Based on comment 8, I'm changing the webcompat status back to needs-diagnosis as it seems there is an additional issue on this site causing the redirection, which is unrelated to / was not fixed by bug 1916002.

Comment 10

[Daniel Holbert [:dholbert]]

I can reproduce that. The error page is actually a crash notification - here's the crash I got just now:
https://crash-stats.mozilla.org/report/index/c8be12dd-fc3a-4a64-9b0f-45b4f0241120

That seems to be tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1931684 , and it looks like we landed a mitigation in the last 24 hours, so hopefully all should be well in tomorrow's nightly.

Raul, would you mind retesting again in a day or so?

Comment 11

[Raul Bucata]

As of today, the crash notification is still present. I will look again tomorrow. Leaving the ni request as a reminder.

Comment 12

[Raul Bucata]

The crash notification is still triggered

Tested with:

Browser / Version: Firefox Nightly 134.0a1 (2016057063-🦎134.0a1-20241119094105🦎)
Operating System: Google Pixel 3 (Android 12) -1080 x 2160 pixels, 18:9 ratio (~443 ppi density)
Operating System: Oppo Find X5 (Android 13) - 1080 x 2400 pixels, 20:9 ratio (~402 ppi density)

Comment 13

[Daniel Holbert [:dholbert]]

Sorry, it seems Nightlies are taking a few days to make it out as play store updates. I think the build you quoted was built just before the crash fix landed (on 11/19)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Yes, Play Store review lag continues to be a factor :-(. We're pushing new builds off for review as often as we can, but right now it's taking 24-48hr for those builds to go live.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Note that we're still building Fenix Nightly builds twice a day, however. All of them can be downloaded and installed from https://archive.mozilla.org/pub/fenix/nightly/ if you want to avoid the Play Store lag.

Comment 16

[Daniel Holbert [:dholbert]]

11-20 nightly is now out via play store, which fixes the crash that was blocking us from testing the login page here.

With that, I can reach the login page and scroll to see the buttons even when the keyboard is up. So I think we can consider this fixed by bug 1916002 (edit: fixed bug number typo)