1884807 - Change the default interactive-widget value to resizes-visual on the Nightly channel

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

We are implementing interactive-widget in bug 1831649 in compliance with the spec definition, but one thing we are not applicable is that the default value. The spec defines that the default value is resizes-visual, but it will change our default behavior so that it will probably some sites in the wild. So initially in bug 1831649 we are going to use resizes-content which is our current behavior by default.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

The new nav bar on Fenix introduced a new behavior, it appears on normal browsing browser mode, it disappears while the software keyboard is visible. That means;

1. while the software keyboard is not visible the nav bar height affects the layout viewport
2. while the software keyboard is visible the nav bar height doesn't affects the layout viewport

Petru fixed a layout issue (bug 1908249) by calling setDynamicToolbarMaxHeight with a different height, but apparently it's not a proper fix. We need a new API for the nav bar (bug 1912008). Without fixing it we can't change the default interactive-widget mode unfortunately.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

In terms of web compatibilities bug 1912008 might not be a big problem since on Chrome I can see a resize event on resizes-visual mode as well, the behavior violates the spec definition though.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

I just added two dependent bugs here. But Botond and I agreed on that those bugs (including bug 1912008) are less severe than blocking bugs such as bug 1842574, bug 1884131 and bug 1826410).

So we are going to change the default interactive-widget value to resizes-visual here, nightly only to see whether there's any significant negative impacts on users or not, and if not, we are going to ship it on beta/release channels.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1884807 - Change the default interactive-widget value to resizes-visual behind a pref. r?botond

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3b41efabc69
Change the default interactive-widget value to resizes-visual behind a pref. r=botond

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c3b41efabc69