Closed Bug 1884278 Opened 7 months ago Closed 7 months ago

Add an exception from a11y_checks for clicks on a not focusable pinned media button on Firefox View

Categories

(Firefox :: Firefox View, task, P3)

task

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
firefox125 --- fixed

People

(Reporter: ayeddi, Assigned: ayeddi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The Firefox View tests, i.e. browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js:test_mute_unmute_pinned_tab sends a click on a pinned mute/unmute control that is intentionally made not focusable to follow the existent tab panel behavior.

A keyboard-only user could mute/unmute this pinned tab via the context menu, while we do not want to create an additional, unnecessary tabstop for this control as well. Thus we add an exception from the a11y_checks for this tests via setEnv and remove the fail-if notation from its test manifest.

The a11y-checks is currently reporting:
Node is not focusable via the accessibility API: id: fxview-tab-row-media-button, tagName: BUTTON, className: fxview-tab-row-pinned-media-button -

The Firefox View tests, i.e. browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js:test_mute_unmute_pinned_tab sends a click on a pinned mute/unmute control that is intentionally made not focusable to follow the existent tab panel behavior.

A keyboard-only user could mute/unmute this pinned tab via the context menu, while we do not want to create an additional, unnecessary tabstop for this control as well. Thus we add an exception from the a11y_checks for this tests via setEnv and remove the fail-if notation from its test manifest.

Depends on D203987

Assignee: nobody → ayeddi
Status: NEW → ASSIGNED
Blocks: 1854625
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bf2d33d8d60 Add exceptions from a11y_checks for clicks on a not focusable pinned media button on Firefox View. r=kcochrane,fxview-reviewers
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: