1884661 - When filtering passwords in the password manager, removing an entry leaves empty list entries

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[[e-mail]]

Attachment: password-delete.png

Steps to reproduce:

• Open preferences
• Open privacy & security
• Open saved passwords
• Filter by some chars
• Delete entry

Actual results:

Entry is "emptied" out, but row remains. Other empty rows are also created at the end of the list which is rather confusing.
The attached picture shows the state after deleting the corresponding SMTP entry.

Expected results:

The selected row should be removed.

Looks like bug 1874646 didn't provide a complete fix, also likely bug 1876733.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1884661 - Fix reloading of signons when "passwordmgr-storage-changed" is observed. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/48f31f2e6dcb
Fix reloading of signons when "passwordmgr-storage-changed" is observed. r=mkmelin

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9390613 [details]
Bug 1884661 - Fix reloading of signons when "passwordmgr-storage-changed" is observed. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1874646
User impact if declined: Broken view of passwords after deleting a password
Testing completed (on c-c, etc.): c-c and beta. If approved, maybe should be taken together with bug 1301248, since they affect the same code and have been checked in together.
Risk to taking this patch (and alternatives if risky): rather low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9390613 [details]
Bug 1884661 - Fix reloading of signons when "passwordmgr-storage-changed" is observed. r=#thunderbird-reviewers

[Triage Comment]
Thanks for the patch.
Declining uplift because this isn't a severe problem, even though it is a recent regression