1874646 - When filtering passwords in the password manager, editing a password, removing an entry or clearing the filter hides every entry from the list

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect, P3)

Description

[thor]

Steps to reproduce:

• Open preferences
• Open privacy & security
• Open saved passwords
• Filter by some chars (e. g. "example.com")
• Click "Show passwords"
• Right-click on an entry and click "edit password"
• Edit password
• Click somewhere else to release focus/confirm change

Actual results:

Password gets changed but the whole list is now empty. Removing the filter does not restore the list. The saved passwords window needs to be reopened.

Expected results:

The list should not be cleared.

Comment 1

[Brendan Abolivier [:babolivier]]

Thanks for taking the time to report this bug! I can reproduce it locally - also it seems the same issue occurs when clearing the filter (no entry is shown in the list if I filter then clear the filter).

This seems to be a regression since I cannot reproduce this bug locally on 102. Though a quick look at the history of https://searchfox.org/comm-central/source/mail/components/preferences/passwordManager.js hasn't allowed me to find when it was introduced. Using moz-regression to answer this question is probably a good next step.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Regression window, but apparently regressed by bug 1839066, since backing out https://hg.mozilla.org/mozilla-central/rev/2b2f7fab33a13904ee9ba50833a2bd509707420d fixes this.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1874646 - Fix reloading of signons in password manager. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f8dfb3f2a22
Fix reloading of signons in password manager. r=emilio

Comment 6

[Magnus Melin [:mkmelin]]

Please request uplifts.

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9375697 [details]
Bug 1874646 - Fix reloading of signons in password manager. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1839066
User impact if declined: The user may get the impression that all his passwords are gone.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): none

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9375697 [details]
Bug 1874646 - Fix reloading of signons in password manager. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 123.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/495dadf28a10

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9375697 [details]
Bug 1874646 - Fix reloading of signons in password manager. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 115.8.0:
https://hg.mozilla.org/releases/comm-esr115/rev/5b01317232f9