1884901 - about:translations stops working until reloading the page

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[:gerard-majax]

Not sure exactly of the STRs, but it has happened recurrently for me recently.

STR (hopefully):

1. Open about:translations
2. Source language as German
3. Target language as French
4. Paste some german text in the input field
5. Translation works
6. Switch to another page, select new text
7. Paste in input the new text

Expected:
Translation updates

Actual:
Sometime not. You need to reload.

I dont know if it matters if I select all then remove, or just select all and paste over.

There was no error visible in consoles.

Comment 1

[Erik Nordin [:nordzilla]]

(In reply to :gerard-majax from comment #0)

Thanks for reporting this!

I discovered this issue just earlier this week while working on Bug 1870316, but I hadn't had a chance to file an individual bug for this. Moreover, my patch for Bug 1870316 should fix this bug as well, but we can confirm when it lands.

The issue is that the Translator class that manages communication with the TranslationsEngine for the about:translations page is lacking logic to detect if the TranslationsEngine has closed the channel of communication with the MessagePort from the other end.

Currently, when this happens, about:translations continues to send requests over a port that has been closed.

I will assign this bug to myself so someone else doesn't pick it up in the meantime. I'm hoping to get my patch landed this week so this should be fixed soon.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1884901 - Move Translator class to Translator.sys.mjs r=#translations-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/388f3f942998
Move Translator class to Translator.sys.mjs r=translations-reviewers,gregtatum

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/388f3f942998