Fix Translator Exception Handling
Categories
(Firefox :: Translations, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox125 | --- | unaffected |
| firefox126 | --- | wontfix |
| firefox127 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Description
Bug 1884901 introduced a new Translator.mjs abstraction, which works well for the happy path, but has a race condition in the event that the Translations Engine fails to be constructed that results in an unhandled promise rejection.
Steps to implement
- Fix the code so that all promise rejections are caught gracefully.
Tests to implement
- Test coverage is handled by 1870307 (subsequent patches in the stack) which test SelectTranslationsPanel error states.
|
Assignee | |
Comment 1•7 months ago
|
||
Fixes an issue where an exception was not being
caught correctly if the Translations Engine failed
to be created for SelectTranslations.
Depends on D207603
|
||
Comment 2•7 months ago
|
||
Set release status flags based on info from the regressing bug 1884901
|
||
Updated•7 months ago
|
|
||
Comment 4•7 months ago
|
||
| bugherder | ||
|
|
||
Comment 5•7 months ago
|
||
The patch landed in nightly and beta is affected.
:nordzilla, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox126towontfix.
For more information, please visit BugBot documentation.
|
|
Assignee | |
Comment 6•7 months ago
|
||
I'm marking this as wontfix because the locations where this code is used are not yet in production.
This is used by the about:translations page, which is not an "offical" page and is not included in about:about. The page has no official UX design work and only minimal testing. It is a debugging ground for translations developers.
The other place this is used is in the SelectTranslationsPanel which is still preffed off in Firefox 126.
Description
•