1891253 - [Menu Redesign] Display the correct state in the Mozilla account button

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Followup to https://phabricator.services.mozilla.com/D207053#7108155, where we need to add some form of AccountState inside of our SyncStore which is currently missing and as a result we are not properly able to display the state where we need to reauthenticate the account.

Note, I believe that only AccountUiView is displaying the correct sync states in a button at the moment compare to BrowserMenuSIgnIn

The task here is to do the following:

• Add an AccountState to the SyncState that is managed by SyncStore
• Observe the new AccountState from the SyncStore in the menu dialog in order to provide the correct properties to MozillaAccountButton.
• Implement the correct navigation to the appropriate fragments given the AccountState. This should follow AccountUiView.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1891253 - Part 1: Add AccountState to SyncStore

• Adds an AccountState to the SyncState that is managed by SyncStore
• This follows closely to accountStateSideEffects in https://searchfox.org/mozilla-central/rev/83ac77eef5a02e3c7d0d6bcc1e28a8f0700d4b5e/mobile/android/android-components/components/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/manager/FxaAccountManager.kt#507 where we map the AccountState to when the observer callbacks are notified.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1891253 - Part 2: Observe the AccountState from the SyncStore in the menu dialog

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1891253 - Part 3: Implement navigation to the Mozilla account screens from the Mozilla account menu button

• Implement the correct navigation to the appropriate Mozilla account fragments given the AccountState
• Navigation flow follows:
  https://searchfox.org/mozilla-central/rev/83ac77eef5a02e3c7d0d6bcc1e28a8f0700d4b5e/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMenuController.kt#233
  https://searchfox.org/mozilla-central/rev/83ac77eef5a02e3c7d0d6bcc1e28a8f0700d4b5e/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt#122

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a4ab46225c0
Part 1: Add AccountState to SyncStore r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/d80c214825c1
Part 2: Observe the AccountState from the SyncStore in the menu dialog r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/2f0f2cbeef3f
Part 3: Implement navigation to the Mozilla account screens from the Mozilla account menu button r=android-reviewers,matt-tighe

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1a4ab46225c0
https://hg.mozilla.org/mozilla-central/rev/d80c214825c1
https://hg.mozilla.org/mozilla-central/rev/2f0f2cbeef3f

Comment 6

[Lina Butler (ex-Mozilla)]

Hi :gl! I wonder if this patch stack could be causing the assertion in bug 1908838, and the recent spike in Sentry errors from bug 1909779?

Specifically, I'm wondering if calling authenticatedAccount.getProfile()? inside FxaAccountObserver.onReady() causes getProfile() to update the account state and log the user out as a side effect, then notify AccountAbnormalities.onLoggedOut() before AccountAbnormalities.onReady() has had a chance to run. Could that explain what's happening here?