1886064 - Make usage of label and comment in autocomplete items more consistent

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, enhancement)

Description

[Neil Deakin]

Currently, the label and comment fields of a result are sometimes reversed, or used in an inconsistent manner.

The plan here is to make the fields more consistent:

label - the primary label to be used on the autocomplete popup item.
value - the value to be filled in to the field.
comment - a serialized object containing any other fields.
finalCompleteValue - the value to be filled in to the field, but I couldn't find in which situation this differs from the value (all implementations that I can see just return value)

Comment 1

[Neil Deakin]

Attachment: Bug 1886064, make usage of label and comment fields in autofill items more consistent, r=#credential-management-reviewers

Depends on D207438

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac7bca16ad74
make usage of label and comment fields in autofill items more consistent, r=credential-management-reviewers,geckoview-reviewers,reusable-components-reviewers,owlish,sgalich,tgiles

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ac7bca16ad74