1910073 - nsAutoCompleteController::GetValueAt() returns the label instead

Status: NEW

(Toolkit :: Autocomplete, defect)

Description

[Marco Bonardo [:mak]]

NS_IMETHODIMP
nsAutoCompleteController::GetValueAt(int32_t aIndex, nsAString& _retval) {
  GetResultLabelAt(aIndex, _retval);

  return NS_OK;
}

I'm not sure why it's not using GetResultValueAt, as it is calling controller.GetValueAt() returns the label.
There's a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=556007#c53 that seems to indicate this was done on purpose but eventually it should have been fixed.
I suspect it was mostly a compatibility decision for add-ons?

It's hard to tell if fixing this would break something, so it may require some testing.

Comment 1

[Marco Bonardo [:mak]]

I put a workaround in the test for bug 1909211, using getFinalCompleteValueAt instead of getValueAt.