1886761 - Switch to tab and Visit from clipboard buttons aren't vertically centered in their row

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: clipboard result button misalignment

Found in

• Fx 125.0b2

Affected versions

• Fx 126.0a1
• Fx 125.0b2

Affected platforms

• Windows
• macOS
• Ubuntu

Steps to reproduce

1. Launch Firefox and navigate to a website.
2. Copy the website link from the address bar.
3. Open a new tab and click the address bar.
4. Using the keyboard select the Clipboard Result link from the address bar drop-down.
5. Inspect the 'Visit from clipboard' button.

Expected result

• Button is correctly displayed.

Actual result

• Button is not vertically centered.

Regression range

• First bad: 2024-01-18
• Last good: 2024-01-17
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=71000174812fc0992b6793e53ac5f11f1b87bdc0&tochange=8a42b9c1ec665c4d577ef6c0a0a5b073d172fda6
• Potentially regressed by: From that pushlog only bug 1851481 stands out.

Additional notes

• This is more noticeable on mouse hover or keyboard selection.
• Please note that the text inside the button is correctly aligned to the link text.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1851481

:dao, since you are the author of the regressor, bug 1851481, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #0)

Created attachment 9392519 [details]
clipboard result button misalignment

Regression range

• First bad: 2024-01-18
• Last good: 2024-01-17

With a good build, is the button vertically centered on your end? When I restore the center alignment (undoing bug 1851481), I just get misalignment in the other direction, i.e. it moves the button closer to the top edge of the row. I can't seem to really center the button, as there seems to be an unequal amount of pixels that we can't split evenly. This may depend on your system font though. I'm on Ubuntu...

Comment 3

[Cristian Baica [:cbaica], Release Desktop QA]

Hello Dão,
Yes, with a good build, the button is vertically centered. I'm not using any custom fonts or have manipulated them in any way. I'm using 'standard' Windows 10 fonts. I'll attach a new screenshot containing one of the good builds.
Unfortunately, on Ubuntu, not even on a 'good' build the button is not centered, but the position is different (the larger space is below).

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: visit from clipboard good build

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1886761 - Make switchtab/remotetab/clipboard chiclets slimmer so that a mismatch in their top and bottom distances to the row's edges is less obvious. r=adw

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc7196a81613
Make switchtab/remotetab/clipboard chiclets slimmer so that a mismatch in their top and bottom distances to the row's edges is less obvious. r=adw

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dc7196a81613

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Marking the issue as verified fixed on Fx126.0b1 and Fx127.0a1 on Windows 10 and Ubuntu 23.04. The difference in distance is less obvious, but the issue is still present.