1851481 - 'Search with <engine>' is not aligned to the suggestion

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: misalign search with

Found in

• Fx 119.0a1

Affected versions

• Fx 119.0a1
• Fx 118.0b4
• Fx 117.0

Affected platforms

• Windows 10
• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox.
2. Input a search term in the address bar.
3. Inspect the first option in the drop-down then hover over other suggestions.

Expected result

• "Search with <engine>" is aligned with the search suggestion.

Actual result

• "Search with <engine>" is not aligned with the suggestions.

Regression range

• First bad: 2021-05-05
• Last good: 2021-04-05
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=de11c0fbd90155ddd1fc8450b45ed99a55c3c2cf&tochange=65dc61a78542a0521d4c9a42ff7bd152a88029fc
• This is not a recent regression, looks like it was like this from the launch of proton.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:cbaica, could you try to find a regression range using for example mozregression?

Comment 2

[Mark Banner (:standard8)]

Not worth tracking as a regression, as it is a visual change and has been like it for > 2 years already.

The misalignment seems to happen because of the different sizes of text either side of the dash. We should test out aligning them and see what it looks like and then make a decision on fixing this.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1851481 - Clean up vertical alignment within result rows. r=adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a42b9c1ec66
Clean up vertical alignment within result rows. r=adw

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8a42b9c1ec66

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-01-15 Nightly build on Windows 10.
Verified as fixed on Firefox 123.0b8 and Firefox Nightly 124.0a1 on Windows 10, Ubuntu 22, macOS 12.