1887518 - Dragging a message does not select that message

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[pwilly]

Steps to reproduce:

Dragging a message (click down + hold + drag) should select the message (if not dropped into another folder). This was the case up to TB 102 and in any other Windows app.

Actual results:

The dragged message is not selected. Messages get only selected on the mouse up click event which doesn't occur on dragging.

Expected results:

The dragged message should become selected on the mouse click down event (or the moment you start dragging) like it is common in Windows and any other application.

This is important if you drag a message outside the native TB window and drop it (i.e. on the Windows desktop or another application). You do not see in the TB message pane which message you have dragged. Make the message selection and dragging behaviour like it was in TB 102 please.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Confirmed. This would also largely resolve bug 1889901.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1887518 - Make sure a message is selected when dragging. r=#thunderbird-front-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4daaaff21108
Make sure a message is selected when dragging. r=freaktechnik

Comment 4

[Corey Bryant]

Hartmut, is this ready for beta uplift?

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9426185 [details]
Bug 1887518 - Make sure a message is selected when dragging. r=#thunderbird-front-end-reviewers

Yes, Corey, I don't think there's any notable risk.

Comment 6

[Corey Bryant]

Comment on attachment 9426185 [details]
Bug 1887518 - Make sure a message is selected when dragging. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Corey Bryant]

Thunderbird 132.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/2ca8c34a411a

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9426185 [details]
Bug 1887518 - Make sure a message is selected when dragging. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Testing completed (on c-c, etc.): more than two weeks in beta
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Corey Bryant]

Comment on attachment 9426185 [details]
Bug 1887518 - Make sure a message is selected when dragging. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr128

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 128.4.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/2203cd0c2b36