1889240 - Translate Button Sometimes Overlaps with Reader Mode and Review Checker

Status: RESOLVED FIXED

(Fenix :: Translations, defect, P1)

Description

[Olivia Hall [:olivia]]

STR:

• Have translations enabled

• Go to a Wikipedia article in another language that the system language so both the Translations and Reader Mode icon should appear

• Continually drill down to subsequent Wikipedia article links until the bug appears

  • I clicked links at a fairly quick pace, was able to reproduce consistently x3
  • The bug is the icons overlap and stay overlapped until navigation

• Generally have to click through very quickly to have this issue.

Some screenshots of the behavior here.

Comment 1

[Olivia Hall [:olivia]]

Noticed the overlap is especially pronounced when turning reader mode on and off with the change in bug 1884769. I think the reader mode transition might be causing the overlapping behavior or making it worse.

Comment 2

[Olivia Hall [:olivia]]

Bug 1891192 and this one are very related. Bug 1891192 has a good video of the issue.

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1889240 - Fix toolbar actions overlapping each other

Comment 4

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Nightly blockers to priority P1.

Comment 5

[miralobontiu]

Just encountered this issue on a fresh install:

1. Opened mozilla.org/fr, and from the translations bottom sheet tapped on the "Learn more" hyperlink.
2. The SUMO page opened in a new tab.
3. Swipe from the SUMO tab to the tab from step 1, and observe the overlapped icons.

Reproducible 100%. Tested on today's Nightly 127.0a1 from 5/9, with a Lenovo tab M10 (Android 10).
Not reproducible on Google Pixel 6 (Android 14).

Comment 6

[Olivia Hall [:olivia]]

Thanks for testing and finding an easier STR! Mike has a patch proposal to fix this issue and it is finishing review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4275f8979796
Fix toolbar actions overlapping each other r=android-reviewers,giorga,ohall

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4275f8979796

Comment 9

[Pascal Chevrel:pascalc]

Backed out for beta 2 as requested by mavduevskiy for causing crashes (bug 1896347)
The patch is not backed out of Nightly.
https://hg.mozilla.org/releases/mozilla-beta/rev/a185984cbd6ad270dab52c7cb78bd327f90d57bd

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mavduevskiy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval. Also, don't forget to request an uplift for the patches in the regression caused by this fix.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.